python-manilaclient

Past-due removal of deprecated kwargs (removal_version 6.0.0)

Bug #2146287 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
In Progress
Low
Silvia Wachira

Bug Description

Current version is 6.0.0. Three kwargs (use_keyring, force_new_token, cached_token_lifetime) on both v1.Client and v2.Client were deprecated in 5.8.0 with removal_version='6.0.0' but are still present:

v2.Client:
https://opendev.org/openstack/python-manilaclient/src/commit/3996ff3e6aba50d8b7a4c705857f3a0401210660/manilaclient/v2/client.py#L87-L104

v1.Client:
https://opendev.org/openstack/python-manilaclient/src/commit/3996ff3e6aba50d8b7a4c705857f3a0401210660/manilaclient/v1/client.py#L71-L88

Additionally, the v1.Client class itself has removal_version='2.0.0' (current is 6.0.0):
https://opendev.org/openstack/python-manilaclient/src/commit/3996ff3e6aba50d8b7a4c705857f3a0401210660/manilaclient/v1/client.py#L37-L38

Fix: Remove the deprecated kwargs and their @removals.removed_kwarg decorators from both clients. Consider removing v1.Client entirely or updating its removal_version.

Goutham Pacha Ravi (gouthamr)
Changed in python-manilaclient:
importance: Undecided → Low
tags: added: low-hanging-fruit
Vida Haririan (vhariria)
Changed in python-manilaclient:
status: New → Triaged
Silvia Wachira (silvia-wachira)
Changed in python-manilaclient:
assignee: nobody → Silvia Wachira (silvia-wachira)
Revision history for this message
Silvia Wachira (silvia-wachira) wrote :

I've removed the deprecated kwargs from both clients. For v1.Client itself, should I remove it entirely or update the removal_version?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/983616

Changed in python-manilaclient:
status: Triaged → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.