Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Roll Chrome Android ARM32 Orderfile from btZ7w0jAL7HsEkrTC... to ovw_J_zUeq_0b88Dq...
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I3f7b14cd8f1baa253974a77a4c4de72870b932b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8411454
Bot-Commit: [email protected] <[email protected]>
Commit-Queue: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698566}
[Actor] Separate tab loading into placeholder/original accessors
Refactor tab loading in BackgroundTabPool into explicit placeholder
(loadTabByPlaceholderId) and original ID (loadTabByOriginalId)
accessors, sharing a private loadTabInternal helper. Enforce an
assertion that live tabs are never loaded through cold tab
restoration paths, ensuring strict separation between in-memory tab
management and cold deserialization.
Update all existing callers and unit tests to use
loadTabByPlaceholderId.
Bug: 543113015
Change-Id: I04706d19959d4d455a11e58e57cd2de1513bfef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8394938
Reviewed-by: Calder Kitagawa <[email protected]>
Commit-Queue: Fiaz Muhammad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698565}
Remove kBatteryBadgeIcon feature flag and legacy battery icons
TAG=agy
CONV=6c10d25e-16e9-470a-8be4-e791bbdab081
Bug: b:558334457
Change-Id: I9a1fd1bd2c59b823172d1e453e1a5e3812abdc77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8368160
Commit-Queue: Zoraiz Naeem <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698564}
glic: Migrate experimental triggering API from postMessage to Mojo
Migrate experimental triggering API from postMessage transport to direct Mojo communication with ExperimentalTriggeringClient and ExperimentalTriggeringUpdatesHandler.
- Collapse host and client TypeScript code into experimental_triggering_client.ts.
- Delete experimental_triggering_host.ts and experimental_triggering_types.ts.
- Log UMA request counts for OnExperimentalTriggeringUpdate in C++.
- Update BUILD.gn, request_types.ts, conversions.ts, host_from_client.ts, and glic_api_host.ts.
Bug: b:555229109
Change-Id: I62ddf613f2d2b4c22bd036f8725c58316a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8394969
Reviewed-by: Wei Guo <[email protected]>
Reviewed-by: Charles Harrison <[email protected]>
Commit-Queue: Dan H <[email protected]>
Reviewed-by: Bryant Chandler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698563}
Print RemoteFrame information in PrintFrames
Change-Id: Iac009018eef89cf392757766c9c8df3ecb57e51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8415095
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Xianzhu Wang <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698562}
[Extensions] Enforce mDNS permission checks.
MDnsAPI::IsMDnsAllowed previously only checked whether the extension was
enabled in ExtensionRegistry, without verifying whether the extension
held the restricted 'mdns' permission.
This CL fixes this by:
1. Verifying that the extension possesses the kMDns API permission in
MDnsAPI::IsMDnsAllowed.
2. Enforcing a browser-side limit of 10 listeners per extension in
MDnsAPI::GetValidOnServiceListListeners so that compromised
renderers cannot bypass the JS-level maxListeners limit to exhaust
resources.
3. Adding unit tests in mdns_api_unittest.cc and browser tests in
mdns_apitest.cc verifying that unauthorized extensions cannot add
listeners and extra listeners beyond 10 are ignored.
Fixed: 513850046
Change-Id: I22e0bd4ebc18979883566605fec66cbb24987ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8411968
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Mark Foltz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698561}
[ReadAloud] Require audio initialization for playback readiness (CL 2)
Adds IsAudioInitialized() predicate to ReadAloudPlaybackController
and integrates it into IsReadyToPlay(). Defers Play() requests
received before InitializeAudio() completes and automatically triggers
playback via MaybePlayOnReady() upon audio setup.
Bug: 561554575
Change-Id: I5530e699429fcd5fab1d8b8269ca7badc753dfe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8403773
Commit-Queue: Andres Molina <[email protected]>
Reviewed-by: Roberto Rodriguez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698560}
chromeos/CHROMEOS_LKGM: Automatic uprev to 16823.0.0-1080281.
Diff Link: http://crosland/log/1080279..1080281
Generated by PUpr, see https://cr-buildbucket.appspot.com/build/8670556886408090129 for job details.
BUG=None
TEST=CQ
Pupr-Upstream-Versions: [{"ref": "refs/heads/snapshot", "repository": "/chromeos/manifest-internal", "revision": "8ea06e583a2aceca834c32713a125a77c60e8dfd"}]
Cq-Cl-Tag: pupr:chromeos-lkgm
Override-Tryjobs-For-Automation: luci.chrome.try:chromeos-betty-chrome-gtest-and-tast,chromeos-brya-chrome,chromeos-jacuzzi-chrome,chromeos-reven-chrome,chromeos-trogdor-chrome,chromeos-volteer-chrome; luci.chromium.try:chromeos-amd64-generic-rel,chromeos-arm64-generic-rel,linux-presubmit,win-presubmit
Change-Id: I44de27770c53d4f7fe4264fe90efe6e46dd57dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8416505
Bot-Commit: [email protected] <[email protected]>
Commit-Queue: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698559}
[AIM] Restrict NativePageReparentingTest on desktop
Restrict testBackgroundNtpFrozenOnReparenting and
testNtpReparentingPreservesTabAndRecreatesNativePage away from desktop
due to flakiness on android-internal-desktop-x64-rel.
TAG=agy
CONV=a59fd189-448c-4127-82dc-47a0e25aeb37
Bug: 562155405
Change-Id: Idd50c265c90f4f5dc56535b1eefbc0f83a53f614
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8416267
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698558}
Remove kNotificationWidthIncrease feature flag
Feature has been enabled since M133.
TAG=agy
CONV=991af677-2e1b-41f8-8050-141e3e537558
Bug: b:558334457
Change-Id: I93b86e353e8d204d15f19a126944c7de79d7cdb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8367766
Commit-Queue: Zoraiz Naeem <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698557}
ash: Fix thread violation and data race in ExternalLoader
When async=true, ExternalLoader was posting ExternalLoader::Load to
base::ThreadPool with base::Unretained(this). Inside Load, it called
g_browser_process->GetApplicationLocale(), which accessed
ApplicationLocaleStorage on a background thread in violation of its
sequence checker. Furthermore, calling default_app_order::Get on the UI
thread before Load finished resulted in concurrent unsynchronized access
to app_ids_, and destroying ExternalLoader during early shutdown caused
a use-after-free hazard.
This CL resolves these issues by:
1. Resolving the locale on the UI thread and injecting it into
ExternalLoader.
2. Removing browser_process.h from default_app_order.cc.
3. Decoupling file loading into a standalone function dispatched via
base::ThreadPool::PostTaskAndReplyWithResult.
4. Using base::WeakPtr on the UI sequence to safely drop reply callbacks
upon early destruction, eliminating base::Unretained(this).
5. Ensuring app_ids_ is accessed exclusively on the UI thread and adding
a TODO to introduce a completion callback or observer.
6. Adding unit tests covering localization, async loading, and premature
destruction.
TAG=agy
Bug: b:559471293, b:404131876
Change-Id: I712a26e61cc1850d64808704a4f22bd4add9966e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8377530
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Jun Ishiguro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698556}
Roll Perfetto Trace Processor Linux from d5cda445c114 to bf392516c5fc
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/d5cda445c114..bf392516c5fc
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I1094bc0cad91871efc85bbdc030c3134a36ce8b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8415748
Commit-Queue: [email protected] <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698555}
[Audio] Remove redundant static_cast on enums in HistogramTester calls
and ExpectUniqueSample that accept enumeration values directly and perform
the underlying sample cast internally. Explicit static_cast<int> calls
at the call sites are redundant.
base: :HistogramTester provides templated overloads for ExpectBucketCount
Change-Id: I8fdff554ebcaef0b76231ac4921f64aa45866d3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8413095
Commit-Queue: Thomas Guilbert <[email protected]>
Commit-Queue: Michael Wilson <[email protected]>
Reviewed-by: Thomas Guilbert <[email protected]>
Auto-Submit: Michael Wilson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698554}
Strip discourse context header on cross-origin redirects
Add a redirect callback to the ContextualSearchDelegateImpl URL loader
to manage header persistence across navigation hops. When a redirect
targets a different origin, the X-Additional-Discourse-Context header is
explicitly added to the list of headers to remove.
The redirect handler also delegates to RemoveVariationsHeaderIfNeeded to
maintain consistent variations header handling across all default search
engine configurations.
Bug: 513774784
TAG=agy
Change-Id: I5cc2f92d1934a3299f52fd0cd278a9a230a7ae2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8410918
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698553}
[Refactor] Batch ChromeTabbedActivityTest with @Batch(Batch.PER_CLASS)
Batch ChromeTabbedActivityTest with @Batch(Batch.PER_CLASS) and
AutoResetCtaTransitTestRule.fastAutoResetCtaActivityRule().
Dismiss leftover modal dialogs in tearDown() to ensure clean state
between batched tests.
Annotate multi-window, mismatched-indices, and window restoration
tests with @RequiresRestart:
- Temporary ChromeTabbedActivity instance creation/destruction and
early tab persistent store destruction require a fresh process.
- Both testRestoreTabFromClosedWindow_* tests need a fresh process
because TabWindowManagerSingleton.setTabWindowManagerForTesting()
registers a resetter that sets the singleton back to null, so once
either test has run the shared ChromeTabbedActivity is orphaned from
the TabWindowManager that created its TabModelSelector.
Estimated test runtime reduction: ~530s -> ~211s (~320s / ~60%
reduction) on android-internal-desktop-x64-rel.
Bug: 562053210
Change-Id: I3f6a4f159c85afbbd2247e664db486386a128bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8403933
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Henrique Nakashima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698552}
Code Hygiene: Create shared shouldHideDropdown() in composebox_mixin
Change-Id: I79c7b65a1c8223c4b2f957577fa8d0829a6c7bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8411506
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Yvonne Shi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698551}
media: Always decode Opus at 48 kHz in OpusAudioDecoder
In RFC 7845 Section 5.1, Opus audio is always coded and decoded at 48000
Hz by default. FFmpeg's libopusdec unconditionally sets the output
sample rate to 48000 Hz regardless of the configured sample rate (e.g.,
44100 Hz from WebCodecs).
Previously, OpusAudioDecoder passed config.samples_per_second() directly
to opus_multistream_decoder_create(), which caused initialization to
fail with OPUS_BAD_ARG when configured with non-Opus rates like 44.1
kHz.
This patch normalizes OpusAudioDecoder to always initialize at
kOpusDefaultSampleRate (48000 Hz) and disables phase inversion when
targeting mono output, matching FFmpegAudioDecoder's behavior.
TAG=agy
CONV=e613eb01-c26a-4600-820a-03e77c3f7c7d
Fixed: 547065816
Change-Id: Ie3ec3e5acf65ce82735b8e7a430cb5abef0b4cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8408705
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Jordan Bayles <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698550}
[bedrock] Clean up stale BrowserWithTestWindowTest comments
Remove or update comments referencing BrowserWithTestWindowTest in files
that do not inherit from or use the fixture anymore.
TAG=agy
CONV=8421e4d4-5e2d-43b1-8819-ba2e0028d0cb
Bug: 417766643
Change-Id: I33b5347d3b32eb720b1fb8a05d878f78739d028f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8412136
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698549}
Use `kFlowStart/End` instead of `kFlexStart/End` in blink layouts
Use `kFlowStart/End` instead of `kFlexStart/End` throughout the
different layouts in blink. Since this is just changing how we're
internally processing `flow-start/end` and `flex-start/end`, this change
should be no-op.
Bug: 555299635
Change-Id: Iae1758e9659f84c7c92adbf2f36b6281eaedd3e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8373824
Reviewed-by: Yanling Wang <[email protected]>
Reviewed-by: Alison Maher <[email protected]>
Commit-Queue: Celeste Pan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698548}
[gap-decorations] Preserve multicol rule pattern across fragmentation
Per CSSWG resolution [1], a row gap suppressed at a fragmentation
boundary still consumes one value from the gap-decoration pattern, so
list-valued row rules are assigned consistently in fragmented and
unfragmented contexts. Grid implements this already; this change does
the same for multicol.
This change preserves the row-rule pattern, including auto repeaters,
across those fragments.
The break token records where the next fragment should continue in the
row-rule pattern, counting suppressed row gaps but not rows that
continue across a boundary. During painting, this saved position is
combined with the gap's index in its fragment, while the last fragment
provides the total row-gap count needed by auto repeaters. We ignore
spanner main gaps because they do not represent painted row gaps.
[1]
https://github.com/w3c/csswg-drafts/issues/13754#issuecomment-4298143982
Bug: 505387221
Change-Id: Ib2a01dbf125a60c1ea63db4393a831ed5f5fac03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8373741
Reviewed-by: Morten Stenshorne <[email protected]>
Reviewed-by: Alison Maher <[email protected]>
Commit-Queue: Javier Contreras <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698547}
Update the expiry dates of some variations histograms.
Change-Id: I2389e9511327da537c55abe717b5fa19b4d0ed91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8414087
Auto-Submit: Caitlin Fischer <[email protected]>
Reviewed-by: Roger McFarlane <[email protected]>
Commit-Queue: Caitlin Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698546}
[code-health] Clean up stale base::Feature "OfflinePagesNetworkStateLikelyUnknown"
The OfflinePagesNetworkStateLikelyUnknown feature is disabled by default
and was an experiment to ignore offline network state on Android.
This CL removes the feature flag declaration, definition, usage in
OfflinePageRequestHandler, and its associated unit test.
Bug: 356236955
TAG=agy
CONV=aa77e83c-d825-4296-9321-97a5b17e40a7
Change-Id: Iaf8ae766b183a64075754b0c3883a5a08a835262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8399622
Reviewed-by: Justin DeWitt <[email protected]>
Commit-Queue: Alvin Ji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698545}
Roll src-internal from 7062eae54f30 to 2a3bd5c94261 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7062eae54f30..2a3bd5c94261
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:562182940
Tbr: [email protected]
No-Try: true
Change-Id: I6b577a488607e33a021e20a0d8ebf39da0ee74a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8416186
Commit-Queue: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1698544}
[ReadAloud] Defer playback execution until text set (CL 1)
Fixes a race condition where Play() Mojo IPC is received before
SetTextContent() completes in ReadAloudPlaybackController.
Adds PlayIfReady() and MaybePlayOnReady() readiness state machine.
If Play() is called before text_set_ is true, play_on_ready_
is set to true. Once SetTextContent() completes,
MaybePlayOnReady() triggers playback automatically.
Bug: 561554575
Change-Id: Ie376a8d55f46c3ba8c0edf23a703db14ce678fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8403772
Reviewed-by: Roberto Rodriguez <[email protected]>
Auto-Submit: Andres Molina <[email protected]>
Commit-Queue: Andres Molina <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698543}
Add bofengchen@ to NTP owners
Change-Id: Iaf66d41f059c392200b53becc62de4ff9dfdf02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8416765
Auto-Submit: Bofeng Chen <[email protected]>
Commit-Queue: Bofeng Chen <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698542}
[Refactor] Batch ManageSyncSettingsTest with @Batch(Batch.PER_CLASS)
Batch ManageSyncSettingsTest with @Batch(Batch.PER_CLASS). Add clean
state teardown in tearDown() by finishing SettingsActivity instances,
signing out the primary account from SyncTestRule, and clearing the
SYNC_MANAGED preference from PrefService.
Annotate tests with specific isolation requirements (enterprise policy
modifications, account removal, and child/special account seeding)
with @RequiresRestart.
testHistoryOptInDoNotCarryOverFromOneUserToAnother also needs a fresh
process. It signs in as ACCOUNT1, signs out, then signs in as
ACCOUNT2. SigninManagerImpl captures
AccountManagerFacadeProvider.getInstance() once in its constructor and
observes only that instance, while SigninTestRule is a non-static rule
that installs a new FakeAccountManagerFacade for every test. ACCOUNT2
is therefore never seeded into the native AccountTrackerService,
setPrimaryAccount() returns kAccountInfoEmpty, and the sign-in is
aborted. Also finish the first SettingsActivity before signing into
ACCOUNT2 and reopening preferences to avoid window manager transition
delays.
Make testPassphraseCreation wait for the custom passphrase to take
effect before returning. The sync engine applies the passphrase
asynchronously and only then writes the encryption bootstrap token.
SyncUserSettingsImpl::SetEncryptionBootstrapToken CHECKs that a Gaia
ID is still present unless local sync is enabled, so once tearDown()
signs out, the late write aborts the process. Unbatched this was
invisible because the process was torn down anyway; batched, it killed
the shared process partway through the next test and surfaced as an
unexplained CRASH with no stack in the following test's result.
Estimated test runtime reduction: ~750s -> ~180s (~570s / ~76%
reduction) on android-internal-desktop-x64-rel by avoiding full
browser process re-spawns across 45+ tests in the suite.
Bug: 40743432, 562053210
Change-Id: I4d6a6bcc5bd628e2d7b17dc12bfb1b78d6a6e2f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8405112
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698541}
[Churned-User][Clank] Introduce PaymentsChurnedUsersUiDelegate interface
Introduce a dedicated cross-platform PaymentsChurnedUsersUiDelegate
interface in components/autofill with skeleton Android and Desktop
implementations for the Churned Users resurrection UI.
Specifically, this CL:
- Introduces PaymentsChurnedUsersUiDelegate in components/autofill
with ShowPaymentsChurnedUsersUI() to show the resurrection UI for
churned Autofill payments users.
- Adds PaymentsAutofillClient::GetPaymentsChurnedUsersUiDelegate() and
implements it in ChromePaymentsAutofillClient and
TestPaymentsAutofillClient.
- Adds skeleton implementations PaymentsChurnedUsersUiDelegateAndroid
and PaymentsChurnedUsersUiDelegateDesktop in
chrome/browser/ui/autofill/payments/.
Bug: 558880336
Change-Id: I5e4cb15683063ff0f7cd4602b795265ca065f3cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8395486
Reviewed-by: Vinny Persky <[email protected]>
Commit-Queue: Viplav Kadam <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698540}
[PDF Ink Signatures] Allow multiple InkTextInfo to join one /ActualText
This is necessary because sometimes 2D offsets split the text smaller
than harfbuzz glyph clusters but at that point it's not possible to take
substrings which map directly to glyphs. So those InkTextInfo objects
must be joined together with a single /ActualText span.
Bug: 525093248
Change-Id: I55613cc1ce1b7e1be3508903c684304d4d73f839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8350292
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: April Kallmeyer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698539}
[AIM] Add image_create_24dp vector drawable and update Fusebox icon
Add Android vector drawable for Google symbols 2.0 image_create icon
matching the 24dp size and 960 viewport convention of acute_24dp.
Map IconResourceIds.IMAGE_CREATE_VALUE to image_create_24dp while
preserving BANANA_VALUE mapping to create_image_24dp.
Update Fusebox to tint the request type button start icon and omit popup
color filtering when using IMAGE_CREATE, while preserving untinted
multi-color rendering for BANANA.
TAG=agy
CONV=f35adf49-9451-4a1d-863c-98225dc8fdb3
Bug: 559278227
Change-Id: Iac9471b3990ef983c6ad5cc5faed57a751012b63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8379564
Reviewed-by: Jakob Koblinsky <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698538}
Validate navigation parameters in Lens overlay side panel
LensOverlaySidePanelWebView::OpenURLFromTab forwarded incoming
OpenURLParams directly to BrowserWindowInterface::OpenURL. That path
supplies a null source WebContents, so the popup blocker never ran for
navigations requested from the side panel, and the unvalidated
parameters could cause mismatched FrameTreeNode lookups when a subframe
requested a navigation targeting another frame tree.
Validate requests that originate from the results frame, which renders
remotely served content:
- Restrict forwarded navigations to HTTP and HTTPS schemes.
- Confirm a claimed user gesture against transient activation in the
initiating RenderFrameHost, ignoring any initiator that does not
belong to this side panel.
- Demote dispositions that the popup blocker does not evaluate, notably
SAVE_TO_DISK and OFF_THE_RECORD, to NEW_FOREGROUND_TAB so that the
underlying tab is never navigated and downloads cannot be started
without a gesture.
- Reset the frame tree node identifier.
Validated requests are then routed through the tab's WebContents
delegate instead of the browser window interface, which attributes the
navigation to the tab so that it is evaluated against popup blocking
rules. Consequently the popup content setting is now evaluated against
the tab's URL. Requests from the side panel WebUI main frame originate
from browser-controlled code and continue to be forwarded unmodified.
Bug: 517689673
Change-Id: I89f62b3e84dc7c0d81d6a73fb55c0860c1cb229e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8414217
Commit-Queue: Juan Mojica <[email protected]>
Reviewed-by: Bryan Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698537}
[ash] Remove unused CollapseButton
ash::CollapseButton was used in the pre-QsRevamp system tray to expand
and collapse the quick settings tray. The QsRevamp redesign eliminated
this expand/collapse interaction, rendering the button unused with zero
callers.
BUG=None
TAG=agy
CONV=c0411801-0f04-4a25-aca5-34c5bf7368d1
Change-Id: Ibc38f2a76329a076ed3dde356ef60fe8dfef8755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8356872
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Ahmed Mehfooz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698536}
Roll WebView ARM Orderfile from Q6X3_frjedPlS33XI... to CBG8Btoys5zGkjeFn...
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/orderfile-webview-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I6bfb0b7b2b465265237c5f034fd8d4b8a2a787ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8414470
Bot-Commit: [email protected] <[email protected]>
Commit-Queue: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698535}
Import omnibox protos from google3
Roll omnibox protos from google3 including IMAGE_CREATE
icon ID in icon_resource_ids.proto and latest searchbox
configuration updates.
NO_IFTTT=Config comment/field changes do not affect mojom.
Bug: 556863407
Change-Id: Ib6e8b253be0d50b957a6d459c754eedcaf0c55bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8394453
Reviewed-by: Fred Shih <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Josiah Kiehl <[email protected]>
Auto-Submit: Josiah Kiehl <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Juliet Knighton <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698534}
[AI WPTs] Move Summarizer concurrent summarize WPT to its own file
Move the 'Multiple Summarizer.summarize() calls are resolved
successfully' subtest into a separate test file
(summarizer-summarize-concurrent.tentative.https.window.js).
On NanoV3 CPU, concurrent calls reject with AbortError due to an
on-device model service crash (crbug.com/560176361). Isolating this
subtest allows the remaining five subtests in
summarizer-summarize.tentative.https.window.html to maintain strict
pass expectations without being masked by file-level failure
expectations.
Bug: 560176361
Change-Id: Ib0d8ff70729bbaaaa6526e0adaea16a650d1a450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8394095
Auto-Submit: Isaac Ahouma <[email protected]>
Commit-Queue: Isaac Ahouma <[email protected]>
Reviewed-by: Mike Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698533}
Roll vulkan-deps from f90cd06dfcd9 to aa7ffc423fdc (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/f90cd06dfcd9..aa7ffc423fdc
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/37cf206d6771a067dd72c82712521ed66df8f73c..81f3df51ab1cf14ea35ff35f921241625cfbd7ca
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9abb194732777e849290dbd35e874bf3b91ba17e..25318da789b94854908a15b4c718145e4e63fc87
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/bde79ad2dd832db9180c4a6eca2e84ceb12b1bb0..e146980907071e728176acfb8612641d25aacf09
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/07c454397e2011926bb50378a5c9d58635b0f0bd..db3ce3e46e1c1940a52346b24d2db4c966387a89
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],radial-bots+[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-mac-arm64;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-win-arm64;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel
Bug: None
Tbr: [email protected],radial-bots+[email protected],[email protected]
Change-Id: I3e5051b916eb18d587e167414c3c616118ec0032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8410547
Commit-Queue: [email protected] <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698532}
[bedrock] Remove dead BrowserWithTestWindowTest includes from browser
tests
These browser tests include browser_with_test_window_test.h despite
inheriting from InProcessBrowserTest or TestBrowserDialog and not using
the fixture. Remove the unused includes.
TAG=agy
CONV=8421e4d4-5e2d-43b1-8819-ba2e0028d0cb
Bug: 417766643
Change-Id: Ic24ad0d91da7af2045da49848c27f70e608ee0cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8416265
Reviewed-by: Keren Zhu <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698531}
Roll optimization-guide from 16ad55bf7d11 to e9319062f379
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/16ad55bf7d11..e9319062f379
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:517228178,chromium:559768094
Change-Id: I99f03e1a7896c5dfd54a519ce116d444c541ad9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8414469
Commit-Queue: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1698530}
[Android] Fix navigation to chrome-extension:// URLs from the omnibox
Previously on Android, any chrome-extension:// URL submitted in the
omnibox was intercepted by LocationBarMediator and forwarded to the
extension system as an omnibox keyword query. This prevented users from
directly navigating to extension resource URLs (such as extension
options or popup pages) from the address bar, unlike on other desktop
platforms.
Fix this by properly differentiating between extension keyword matches
and direct URL navigations. Pass whether the autocomplete match is an
extension match to java, and use that rather than ad-hoc comparisons to
extension URLs.
Add tests for the same, including unit tests for the java code and an
end-to-end browser test (that runs on all platforms).
Bug: 554057190
Change-Id: I64eec31a0a03fa5bc65a417387682cbd82d8f9f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8309421
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698529}
Remove expired flag kAccessibilityMouseKeys
The Mouse Keys feature has been enabled by default since M142. This
CL removes the feature flag, makes Mouse Keys unconditionally
available across Ash, removes dead conditional flag checks while
preserving user preference settings in OS Settings UI, and cleans up
flag metadata.
Bug: b:442533618
Test: ash_unittests --gtest_filter=*MouseKeys*
AX-Relnotes: n/a.
Validate-Test-Flakiness: skip
Change-Id: Idd67eb21c857ab91871e6a53aa8be043d8c94f51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8342989
Commit-Queue: Katie D <[email protected]>
Reviewed-by: Tzarial <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698528}
[GEiC] Bind GEiC sign-in handler by removing policy gate
The GeminiEnterpriseHandler Mojo interface (OpenSignInTab /
CloseSignInTab) was bound only when
GlicEnabling::GetGeminiEnterpriseSettings() returned a value, which
requires the project_id/app_id/location tuple. That tuple belongs to
Gemini Enterprise as a Tool and is unrelated to GEiC, so a
GEiC-configured client never received the interface and sign-in silently
did nothing.
Removing the gate rather than replacing it, as it was superfluous
anyway. A follow-up change will introduce an explicit per-profile "is
Gemini Enterprise" signal evaluated before the instance is created.
Bug: 561699589
Change-Id: I1b9b6b18999885498475226f23a09b200fd4fab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8408546
Reviewed-by: Austin Zhang <[email protected]>
Reviewed-by: Syed Albiz <[email protected]>
Commit-Queue: Bryant Chandler <[email protected]>
Reviewed-by: Dan H <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698527}
Roll Enterprise Companion chromium_win_x86 from 1ecosvZqqc9HDtgyI... to VaRXpDd5qB-_vImoN...
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/ceca-chromium-win-x86-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Enterprise Companion chromium_win_x86: https://g-issues.chromium.org/issues/new?component=1604672&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-enterprise-companion-try-builder-dbg;luci.chromium.try:linux-enterprise-companion-try-builder-rel;luci.chromium.try:mac-enterprise-companion-try-builder-dbg;luci.chromium.try:mac-enterprise-companion-try-builder-rel;luci.chromium.try:win-enterprise-companion-try-builder-dbg;luci.chromium.try:win-enterprise-companion-try-builder-rel
Tbr: [email protected]
Change-Id: Ib0302e2ee861e91c185669d175e2a0e885d26b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8410516
Bot-Commit: [email protected] <[email protected]>
Commit-Queue: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698526}
[Android] Avoid floating action mode overlap with browser controls
On Android, the floating action mode positions its toolbar relative to
the content rectangle provided by onGetContentRect. The previous
heuristic for avoiding overlap with the top controls could lead to
improper positioning during full selections or when content was
scrolled near browser control boundaries.
Update ChromeActionModeHandler to accurately calculate visible top and
bottom browser control offsets when adjusting the selection content
rectangle, ensuring the platform toolbar is positioned clear of browser
controls.
Bug: 329476341
Change-Id: Ia0a9e567a770b7b7b1196c8601655dddb1833ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8393786
Commit-Queue: Jinsuk Kim <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698525}
Roll WebGPU CTS from 32cc9f03ad14 to 81aeeb49e5b1 (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/32cc9f03ad14..81aeeb49e5b1
2026-09-15 16504129+[email protected] Add binding type test for createBindGroupLayout (#4705)
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I42d2eb8f977fac86d53030fa6232b23250e3e94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8416328
Commit-Queue: [email protected] <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698524}
[OmniboxEverywhere] Implement taskbar icon toggle minimization on Windows
Bug: 532195081
Change-Id: Ibb98350060e438f8e31bcc48c4baac6de3870ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8290049
Commit-Queue: Kaan Alsan <[email protected]>
Reviewed-by: Atharv Maan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698523}
[TabUI] Add AndroidTabUiRefactor feature flag
Introduce the AndroidTabUiRefactor flag to guard Grid Tab Switcher
tab group card model architecture updates.
* Register kAndroidTabUiRefactor in ChromeFeatureList and about_flags.
* Add isAndroidTabUiRefactorEnabled helper to TabUiFeatureUtilities.
* Add flag metadata and enum entries.
Bug: 517544602
Change-Id: Ic09e9685e210d57275b3ec367a60a08db4f983dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8412501
Commit-Queue: Gazal Agarwal <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Auto-Submit: Gazal Agarwal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698522}
Roll Chromium Variations from LNP15MTQLUM_LSujj... to ncVXiZoFL0f3OeOd0...
https://chrome-infra-packages.appspot.com/p/chromium/chrome/test/data/variations/cipd/+/ncVXiZoFL0f3OeOd0ieqkjkd9OWd_rLAVsv09MmCWEgC
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/chromium-variations-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Variations: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ib7278679b9caa1748daf443d0de70b2946038c94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8413069
Commit-Queue: [email protected] <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698521}
[Vertical Tabs] Make ESC cancel external drags
After (Please view on a cloudtop):
https://screencast.googleplex.com/cast/NDYwNTU1MTQyOTI4NzkzNnw0MjMxOGMxMC0zYg
HT uses BackpressManager#processEscapeKeyEvent (through TabStripDragHandler) to cancel both internal & external drags.
<Root cause>
For VT, external drag cancel was not working because 7) in the flow below was returning true, calling handleInternalDragEnd() instead of super.handleEscPress().
Flow (for 1 rv):
1) User starts an internal drag (ACTION_STATE_DRAG)
2) Moves the tab past the panel boundary, triggering an external drag
3) For that rv, VerticalTabListCoordinator onDragOutListener calls itemTouchHelper.setExternalDragItem.
createDragHandlerDelegate is called and set as TabSwitchDragHandler's mDragHandlerDelegate.
4) TabSwitcherDragHandler#startTabDragAction
5) User presses ESC -> BackPressManager#processEscapeKeyEvent()
6) TabSwitcherDragHandler's handleEscPress() is called
7) mDragHandlerDelegate.isDragInProcess returns false
8) TabDragHandlerBase#cancelDrag -> mDragSourceView.cancelDragAnDrop()
9) Android OS cancels the drag
10) OriginalDelegate's handleExeternalDragEnd is called
11) itemTouchHelper.onExternalDragStop
Bug: 553670813
Change-Id: I585133cee73aa5041047b9695d1128aaa943c11c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8402544
Reviewed-by: Gazal Agarwal <[email protected]>
Commit-Queue: Eleanor Lee <[email protected]>
Reviewed-by: Jack Thiesen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698520}
Roll Depot Tools from eac62a11aceb to 4a978d8f1f35 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eac62a11aceb..4a978d8f1f35
2026-09-15 [email protected] Validate tar member paths in GCS dependencies and use data_filter
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-utr-tester;luci.chromium.try:win-utr-tester
Bug: chromium:557791048
Tbr: [email protected],[email protected]
Change-Id: I761dde66bc7167c816fff6d1d92b3ab17b1393db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8410811
Commit-Queue: [email protected] <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698519}
Trigger Wallet reminder notice during form submission
This CL integrates WalletReminderNoticeManager with AutofillAiManager to
show a legal reminder notice when submitting forms where the last
accepted suggestion was for an eligible saved Wallet pass, provided no
save, update, or migration prompt is shown.
Key changes:
- Exposes WalletReminderNoticeManager via AutofillClient.
- Updates AutofillAiManager::UserSuggestionInteractionDetails to record
accepted_entity_record_type alongside entity_type_accepted for the last
accepted suggestion on the form.
- Updates AutofillAiManager::OnFormSubmitted() to prioritize save,
update, or migration prompts via MaybeImportForm(), and fall back to
calling MaybeShowWalletReminderNotice() if no import prompt was shown.
- Implements AutofillAiManager::MaybeShowWalletReminderNotice() to check
whether the last accepted entity suggestion is eligible via
IsWalletReminderNoticeEligible() and trigger the notice with
FlowType::kWalletPass.
- Extracts AutofillAiManagerWalletReminderNoticeTest fixture and adds
comprehensive unit tests covering notice triggering, multi-field fills
(last-accepted-entity semantics), suppression scenarios (save prompt
shown, already acknowledged pref, private pass, local saved entity,
entity not filled), and null safety.
Bug: 550184988
Change-Id: I50530a86d9cb7bb3d3f69bdcad2475888fefccf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8292148
Commit-Queue: Cathy Chen <[email protected]>
Reviewed-by: Jihad Hanna <[email protected]>
Reviewed-by: Vidhan Jain <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698518}
Revert "Queue snackbar for after Activity recreate in CrossDeviceSettingImporter"
This reverts commit 87b794d62881516b170e7a9ecf56dfb62879302f.
Reason for revert: CrossDeviceSettingImporterUnitTest is flaking
Failure Link: https://luci-milo.appspot.com/ui/p/chromium/builders/ci/Android%20arm%20Builder%20(dbg)/90490/
Original change's description:
> Queue snackbar for after Activity recreate in CrossDeviceSettingImporter
>
> When a synced setup theme change is applied or undone, the activity may
> recreate to apply dynamic color/theme changes. If the undo/redo
> snackbar is shown before the activity recreation, it will be hidden.
>
> Store pending snackbar presentation state in a static holder scoped to
> the current task ID, restore and display the snackbar when the recreated
> activity regains focus, and clear it upon action or timeout dismissal.
>
> TAG=agy
> CONV=1da233dd-f838-4cd6-ae5f-69c33cc624fb
>
> Bug: 517615321
> Change-Id: I60bcd33e893ebf39c0c2ef0907a04f18a8e0f600
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8384239
> Reviewed-by: Mark Schillaci <[email protected]>
> Commit-Queue: Jenna Himawan <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1697439}
Bug: 517615321, 561744590
Bug: 517615321
Change-Id: I8f42e9ae92fbf7f50514aa17fa58066f8345c9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8407872
Commit-Queue: Sky Malice <[email protected]>
Commit-Queue: [email protected] <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Auto-Submit: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1698517}