Skip to content

authorization headers sensitive data leaks in debug logs #1740

Description

when log level is set to debug, the request object is logged.
this prints all headers, including authorization header.
in case a user has implemented their own credentials mechanism, for example, since Realm object was not sufficient for the authorization scheme (or any other reason) sensitive information can leak.
Bearer scheme authorization is one such example.

a simple fix is to not log authorization headers: when iterating the headers, if the header key is authorization, print something like * authorization data skipped *

this is a simple straighforward solution that is very robust, no matter why the user set headers themselves, no authorization header leak is possible (on the client side), assuming underlying implementation (such as netty) doesn't also log all headers.

Activity

  1. TomGranot commented on Nov 7, 2020

    @TomGranot
    Contributor

    @grunzwei Going to look at this a bit later today - please ping me if I forget.

  2. TomGranot commented on Nov 8, 2020

    @TomGranot
    Contributor

    @grunzwei I'll be taking over maintainership of the repo in the next few days, so more info to come. :)

  3. TomGranot commented on Dec 12, 2020

    @TomGranot
    Contributor

    @grunzwei Did not forget about this - on the list:) If this is still relevant to you then please feel free to open a PR (if not, I'll get to it soon enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions