Avoid allocations in ChannelPoolPartioning #2157

Activity

1. hyperxpro commented on Apr 1, 2026

   

   hyperxpro

   on Apr 1, 2026

   Member

   More actions

   Great find.

   However, using uri.getHost() will only return the hostname, not the port and schema. How about using a record class, something like this:

   record PartitionKey(String scheme, String host, int port) {}

     @Override                                                                                                                                                                                                                                                                                                                                                                                                                                
     public Object getPartitionKey(Uri uri, @Nullable String virtualHost, @Nullable ProxyServer proxyServer) {
         if (proxyServer == null && virtualHost == null) {                                                                                                                                                                                                                                                                                                                                                                                    
             return new PartitionKey(uri.getScheme(), uri.getHost(), uri.getExplicitPort());
         }                                                                                                                                                                                                                                                                                                                                                                                                                                    
         // rest of the code...
     } 

   This will avoid String allocation, and comparisons will be faster too.
2. doom369 commented on Apr 2, 2026

   

   doom369

   on Apr 2, 2026

   Last edited by doom369

   ContributorAuthor

   More actions

   @hyperxpro works for me. do you want me to send PR or you'll do it?
3. hyperxpro commented on Apr 2, 2026

   

   hyperxpro

   on Apr 2, 2026

   Member

   More actions

   Send a PR please :)
4. hyperxpro

   closed this as completedin 2b13737on Apr 9, 2026
5. pull

   added a commit that references this issue on Apr 10, 2026

   Avoid allocations in ChannelPoolPartioning (AsyncHttpClient#2158)

   ...

   2b13737