Repository navigation
Duplicate OPs fix for Android / Linux. - #14
Merged
Merged
Conversation
added 7 commits
April 2, 2020 22:06
|
@bensternlieb : Is there a change we can make to the Readme.MD that will make this more obvious for future readers? |
nathansilberman
approved these changes
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should have read @tgafner’s BUTTERFLY.md more carefully - but anyway, seems the “duplicate operator” problem seen on Android and Linux is likely due to the fact that the iOS build sets the macro ANDROID_TYPES_SLIM to slim down the template instantiations to a minimum number of types for library size reduction while the Android (weirdly) and LInux builds do not.
Our application needs a couple of other types, which folks have added over time, but never with any qualifying wrapper (assuming we’re just compiling for iOS). Again, the Makefiles for both Linux and Android, do not use this slimming macro - and hence the added OPs conflict/Overlap with the full OP set. I’ve wrapped these duplicates in qualifying blocks as follows to remove the conflict so that builds should work regardless of platform. @AlonDaks, @yangliupku, @tomergafner
Note: one exception here - the two "less" op changes are a fix to a plain old duplicate bug.