Skip to content

Errant OTR sessions while in plaintext mode #631

Description

@chrisballinger

I'm not sure what or why this happens yet, but OTR sessions can happen when you're in plaintext mode. I think there's a race condition.

The other side has multiple different clients logged in.

Activity

  1. added this to the 4.1 milestone on Dec 16, 2016
  2. afriedmanGlacier commented on Apr 19, 2017

    @afriedmanGlacier
    Contributor

    Since the default encryption is bestAvailable, when a chat is initiated an OTR session is automatically created if possible in OTRMessagesViewController.updateViewWithKey -> OTREncryptionManager.maybeRefreshOTRSessionForBuddyKey before a user can set it to plaintext. I'm guessing this is what is being referred to in #733

    But after plaintext or OMEMO is selected on the advanced encryption settings of a chat session
    OTRProtocolManager.sharedInstance().encryptionManager.otrKit.disableEncryption is called in UserProfileViewController. This seems to stop the session and any future OTR messaging.

    Are you talking about new OTR sessions occurring after the user has already set a given chat session to plaintext?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions