Repository navigation
add a --configuration option to pod lint. - #9760
Merged
Merged
Conversation
Contributor
Author
|
Tbh I have no clue what's causing the test failure on CircleCI. Are there any actionable errors in the log besides "CompileSwift failed with a nonzero exit code"? |
Member
|
The CircleCI issue might be related to #9761? Is it possible to add a test to spec/functional/command/repo/push_spec.rb? |
Contributor
Author
|
If I understand #9761 correctly, it just removes the creation of a file that is ignored anyway, so I don't think it's related. Also, I'm not sure if .../repo/push_spec.rb is the right place for testing this? Looking at those files, ../lib/list_spec.rc seems to be more suitable to me. I can certainly add a test there. |
paulb777
approved these changes
May 4, 2020
amorde
reviewed
May 7, 2020
gereons
force-pushed
the
lint-configuration
branch
from
May 7, 2020 08:00
ca8be2d to
7d68f49
Compare
amorde
approved these changes
May 7, 2020
Member
|
Thanks for the contribution! |
1 task done
This was referenced Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #9686