Skip to content

Commit 3fa9e24

Browse files
committed
Use "dart run" instead of "dart pub run" for new SDKs
Fixes #3847.
1 parent a730528 commit 3fa9e24

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎src/extension/dart/dart_task_provider.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,9 @@ export class DartTaskProvider extends BaseTaskProvider {
204204
}
205205

206206
protected createPubTask(workspaceFolder: vs.WorkspaceFolder, projectFolder: vs.Uri, args: string[]) {
207-
if (this.dartCapabilities.supportsDartPub)
207+
if (this.dartCapabilities.supportsDartRunForPub && args && args.length && args[0] === "run")
208+
return this.createTask(workspaceFolder, projectFolder, "dart", [...args]);
209+
else if (this.dartCapabilities.supportsDartPub)
208210
return this.createTask(workspaceFolder, projectFolder, "dart", ["pub", ...args]);
209211
else
210212
return this.createTask(workspaceFolder, projectFolder, "pub", args);

‎src/shared/capabilities/dart.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export class DartCapabilities {
2626
get supportsPubOutdated() { return versionIsAtLeast(this.version, "2.8.0-a"); }
2727
get supportsPubDepsJson() { return versionIsAtLeast(this.version, "2.14.0-0"); }
2828
get supportsDartPub() { return versionIsAtLeast(this.version, "2.12.0-0"); }
29+
get supportsDartRunForPub() { return versionIsAtLeast(this.version, "2.16.0-0"); }
2930
get supportsDartDoc() { return versionIsAtLeast(this.version, "2.16.0"); }
3031
get supportsDartDevTools() { return versionIsAtLeast(this.version, "2.15.0"); }
3132
get supportsDartRunTest() { return versionIsAtLeast(this.version, "2.12.0-0"); }

0 commit comments

Comments
 (0)