Repository navigation
Some renames are not supported #144
Description
Splitting this from #31 so we can ship what we have. We abort some refactorings because the AS does something that is not obvious based on the experience in code. Eg:
import 'dart:async';Put your cursor on import and hit F2 and you'll get a box pre-filled with import. Yet what you type in here is used to add an alias.
Once microsoft/vscode#7340 gets implemented we can send a dummy refactor and examine oldName in order to pre-populate the box properly and resolve this. If dart-lang/sdk#27178 gets implemented, then we can remove the hack.
Activity
DanTup commentedon Aug 28, 2016
Seems like we don't need to send a "dummy" refactor to get the oldName, there's a
validateOnlyparam specifically for us to send requests and see if they're valid and also getoldNameand a description of the item being renamed.So once Code supports this properly, we have everything we need for a good implementation, no hacks required! :)
3 remaining items
DanTup commentedon Feb 8, 2018
Looks like Code might be getting support for this:
https://code.visualstudio.com/updates/v1_20#_renameprovider2
Rename range/placeholder for renames
Rename range/placeholder for renames
Rename range/placeholder for renames