Support launching DevTools with the dark theme #1496

Activity

1. DanTup

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Feb 28, 2019
2. DanTup

   added this to the On Deck milestone on Feb 28, 2019
3. audkar commented on Mar 1, 2019

   

   audkar

   on Mar 1, 2019

   More actions

   If we add support, it may have to be a user setting in VS Code to let you choose which theme you want?

   Dark theme is worth my effort to change user setting manually :)

   👍React with 👍3Reacted by Nato Boram, oceanyeung and Niklas Raab
4. DanTup

   closed this as completedin f4e9367on Mar 4, 2019
5. DanTup

   modified the milestones: On Deck, v2.25.0 on Mar 4, 2019
6. DanTup commented on Mar 4, 2019

   

   DanTup

   on Mar 4, 2019

   MemberAuthor

   More actions

   Dark theme will be default from vNext. There's a new setting that lets you set the theme:

   "dart.theme": "light" // or "dark"

   This controls both the icons in tooltips and the DevTools theme. If it turns out that people would like to use different themes for VS Code/icons than DevTools, we can add a separate setting in future.
7. DanTup commented on Mar 12, 2019

   

   DanTup

   on Mar 12, 2019

   MemberAuthor

   More actions

   Not totally happy with how the Dark theme looks right now, so undoing this and re-opening, and will re-evaluate before this version ships.
8. DanTup

   reopened this on Mar 12, 2019
9. DanTup

   added a commit that references this issue on Mar 12, 2019

   Don't use DevTools Dark Theme by default yet

   ...

   22bba0f
10. DanTup

    closed this as completedin fa17317on Mar 18, 2019
11. DanTup commented on Mar 18, 2019

    

    DanTup

    on Mar 18, 2019

    Last edited by DanTup

    MemberAuthor

    More actions

    There are two settings in vNext:

    • dart.theme (defaults to dark)
    • dart.devToolsTheme (defaults to light)

    When the Dark Theme is more polished, I'll change the default of dart.devToolsTheme, but for now you can opt-in to it manually.
12. DanTup

    added

    in commandsRelates to commands (usually invoked from the command Palette)Relates to commands (usually invoked from the command Palette)

    on Mar 21, 2019