Skip to content

Nested /* multi-line */ comments do not colour properly #1498

Closed
Closed
Nested /* multi-line */ comments do not colour properly#1498
Labels
in editorRelates to code editing or language featuresis bug
Milestone
v2.25.0

Description

@DanTup
DanTup
opened on Mar 2, 2019

Looks like our original fix for this only covered those starting with /**, see #456 (comment) (@apaatsio).

I think this should be reopened. I'm still experiencing this.

vscode_dart_nested_comments_highlighting

Dart Code: 2.24.0
Dart VM version: 2.1.2-dev.0.0.flutter-0a7dcf17eb (Tue Feb 12 01:59:15 2019 +0000) on "linux_x64"
VSCode: 1.31.1

Activity

  1. DanTup
    added
    is bug
    in editorRelates to code editing or language features
    on Mar 2, 2019
  2. DanTup
    added this to the v2.25.0 milestone on Mar 2, 2019

  3. DanTup commented on Mar 11, 2019

    @DanTup
    DanTup
    on Mar 11, 2019
    MemberAuthor

    Before/after:

    Screenshot 2019-03-11 at 1 10 38 pm

  4. DanTup
    closed this as completedin 5340e19on Mar 11, 2019

  5. DanTup commented on Mar 11, 2019

    @DanTup
    DanTup
    on Mar 11, 2019
    MemberAuthor

    @devoncarew FYI - in case you think Atom should be updated. Once again, I don't know if I've done this correctly, but it appears to have done the right thing.

    I'm wondering whether we could generate this from something like this file to have it always in-sync and correct 🤔

  6. devoncarew commented on Mar 12, 2019

    @devoncarew
    devoncarew
    on Mar 12, 2019
    Contributor

    Thanks! I opened dart-atom/dart#1185.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions