P0: VS Code: Delegate launching browser to DevTools to always get Chrome #1505

Activity

1. DanTup

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   in commandsRelates to commands (usually invoked from the command Palette)Relates to commands (usually invoked from the command Palette)

   on Mar 4, 2019
2. DanTup

   added this to the v2.25.0 milestone on Mar 4, 2019
3. DanTup commented on Mar 4, 2019

   

   DanTup

   on Mar 4, 2019

   MemberAuthor

   More actions

   This will be handled in the server instead.
4. DanTup

   closed this as completedon Mar 4, 2019
5. DanTup

   removed

   in commandsRelates to commands (usually invoked from the command Palette)Relates to commands (usually invoked from the command Palette)

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Mar 4, 2019
6. DanTup

   removed this from the v2.25.0 milestone on Mar 4, 2019
7. skybur commented on Apr 5, 2019

   

   skybur

   on Apr 5, 2019

   More actions

   Sorry for commenting in this closed issue. So how do I start devtools in chrome if it's not my default browser? Thanks
8. DanTup commented on Apr 5, 2019

   

   DanTup

   on Apr 5, 2019

   MemberAuthor

   More actions

   Currently you'd have to open Chrome manually and copy the URL from the default browser that is launched. This will be fixed, but requires flutter/devtools#463.

   I'm re-opening this, since there will be work today when that lands which I forgot about.

   ❤️React with ❤️1Reacted by Achmad Fadhil Aprilianto
9. DanTup

   reopened this on Apr 5, 2019
10. DanTup

    added this to the v2.26.0 milestone on Apr 5, 2019
11. DanTup

    added

    blocked on dart / flutterRequires a change in Dart or Flutter to progressRequires a change in Dart or Flutter to progress

    in commandsRelates to commands (usually invoked from the command Palette)Relates to commands (usually invoked from the command Palette)

    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

    on Apr 5, 2019
12. 19 remaining items

    Load more
13. DanTup

    added a commit that references this issue on Apr 29, 2019

    Register VM services with DevTools and delegate launching the browser…

    ...

    This issue will close once commit be505bc is merged into the 'master' branch.

    be505bc
14. DanTup commented on Apr 30, 2019

    

    DanTup

    on Apr 30, 2019

    MemberAuthor

    More actions

    I've opened flutter/devtools#611 in the DevTools repo for supporting this from stdin (since this issue will soon be closed). If it's urgent, let me know.
15. DanTup

    added 3 commits that reference this issue on Apr 30, 2019

    Register VM services with DevTools and delegate launching the browser…

    ...

    This issue will close once commit 464037d is merged into the 'master' branch.

    464037d

    Register VM services with DevTools and delegate launching the browser…

    ...

    This issue will close once commit 204b108 is merged into the 'master' branch.

    204b108

    Register VM services with DevTools and delegate launching the browser…

    ...

    This issue will close once commit 8a78454 is merged into the 'master' branch.

    8a78454
16. DanTup

    closed this as completedin #1645on Apr 30, 2019
17. DanTup

    added a commit that references this issue on Apr 30, 2019

    Register VM services with DevTools and delegate launching the browser…

    ...

    This issue will close once commit 934226a is merged into the 'master' branch.

    934226a
18. DanTup commented on May 1, 2019

    

    DanTup

    on May 1, 2019

    MemberAuthor

    More actions

    I'm disabling this for v2.26.1 because I'd like to release the other fixes and there are complications with this. If it fails - most likely because Chrome isn't installed - it seems to unregister the service unexpectedly. I'll put it back in another patch once I'm sure we can handle the failure in a reasonable way.
19. DanTup

    reopened this on May 1, 2019
20. DanTup

    modified the milestones: v2.26.1, v2.26.2 on May 1, 2019
21. DanTup

    added 3 commits that reference this issue on May 1, 2019

    Revert "Revert to launch browser manually"

    ...

    This issue will close once commit 2db7508 is merged into the 'master' branch.

    2db7508

    Revert "Revert to launch browser manually"

    ...

    This issue will close once commit c05bce5 is merged into the 'master' branch.

    c05bce5

    Revert "Revert to launch browser manually"

    ...

    This issue will close once commit 674e912 is merged into the 'master' branch.

    674e912
22. DanTup

    closed this as completedin 674e912on May 2, 2019