Repository navigation
DevTools processes may not be terminated correctly at shutdown #1511
Description
The process ID is different - this is likely because it's the shell (we use shellExecute) or pub is spawning dart.exe.
(PROC 7152) Spawned /home/travis/build/Dart-Code/Dart-Code/with spaces/dart-sdk/bin/pub global run devtools --machine --port 0
(PROC 7152) {"method":"server.started","params":{"host":"127.0.0.1","port":37077}}
(PROC 7152) Calling kill()
(PROC 7152) Exited with code null
Waiting 10 secs before dumping processes...
(Test end): 7153 (1): dart: /home/travis/build/Dart-Code/Dart-Code/with spaces/dart-sdk/bin/dart /home/travis/build/Dart-Code/Dart-Code/with spaces/dart-sdk/bin/snapshots/pub.dart.snapshot global run devtools --machine --port 0
Opened flutter/devtools#402 to expose the real PID, as we do for other processes.
- Land fix in DevTools
- Wait for DevTools release
- Update minimum required version
- Fix this to use PID
- Revert 77271d6
Activity
DanTup commentedon Mar 7, 2019
Turns out NodeJS actually calls this out in the docs (we use shellExecute because on Windows that's the only way to launch a .bat).
SkipDevTools tests on Linux temporarily
Handle terminating DevTools by its real PID
Handle terminating DevTools by its real PID
Handle terminating DevTools by its real PID
Handle terminating DevTools by its real PID
Handle terminating DevTools by its real PID