Skip to content

Allow accessing files outside of "lib" inside Dependencies tree #1590

Closed

Description

@Rodsevich

Ideally, through rightclicking from Dependencies view

Activity

  1. added this to the On Deck milestone on Apr 8, 2019
  2. added
    in editorRelates to code editing or language features
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on Apr 8, 2019
  3. modified the milestones: On Deck, v2.26.0 on Apr 16, 2019
  4. added a commit that references this issue on Apr 16, 2019
    70765b6
  5. DanTup commented on Apr 16, 2019

    @DanTup
    Member

    I implemented this:

    Screenshot 2019-04-16 at 2 03 51 pm

    However I found a problem:

    Screenshot 2019-04-16 at 2 04 01 pm

    If you open it as its own folder (either in a new window, or even as an additional analysis root in for the current window) it doesn't resolve its own dependencies, and therefore everything has squiggles:

    Screenshot 2019-04-16 at 2 04 01 pm

    (it also tries to prompt you to run pub get, though I could fix that).

    I think this is because without a .packages file, it doesn't know where to get these packages from (whereas inside your own project, the .packages file has all transient dependencies).

    So maybe the only way to handle this would be to do your original suggestion, which is to allow the tree to render from the root of the package instead of its lib folder. Or, we could add the folder to the VS Code workspace and exclude it as an analysis root.

    I'll come back to it after doing #1591 to see if anything better comes to me.

  6. Rodsevich commented on Apr 16, 2019

    @Rodsevich
    Author

    Nice! 😄

    allow the tree to render from the root of the package instead of its lib folder. Or, we could add the folder to the VS Code workspace and exclude it as an analysis root.

    Any option would be useful for me, but I think that it would be nice to have both options for the plugin in order to extend the usefulness for the most users possible

  7. modified the milestones: v2.26.0, On Deck on Apr 22, 2019
  8. modified the milestones: On Deck, v3.16.0 on Oct 1, 2020
  9. modified the milestones: v3.16.0, v3.17.0 on Oct 21, 2020
  10. changed the title [-]Add an option to open a dependency package[/-] [+]Allw accessing files outside of "lib" inside Dependencies tree[/+] on Nov 18, 2020
  11. changed the title [-]Allw accessing files outside of "lib" inside Dependencies tree[/-] [+]Allow accessing files outside of "lib" inside Dependencies tree[/+] on Nov 18, 2020
  12. DanTup commented on Nov 18, 2020

    @DanTup
    Member

    The tree now starts one level up from where the package resolves, if the resolved folder is called "lib":

    Screenshot 2020-11-18 at 16 04 03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions