Expose a toggle for profileWidgetBuilds #1612

Activity

1. DanTup

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   in flutterRelates to running Flutter appsRelates to running Flutter apps

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   on Apr 11, 2019
2. DanTup

   added this to the v2.26.0 milestone on Apr 11, 2019
3. DanTup

   added a commit that references this issue on Apr 11, 2019

   Add a toggle for Profile Widget Builds

   ...

   This issue will close once commit dc07146 is merged into the 'master' branch.

   dc07146
4. DanTup commented on Apr 18, 2019

   

   DanTup

   on Apr 18, 2019

   MemberAuthor

   More actions

   Based on Devon's comment at flutter/devtools#508 (comment) I think this toggle only applies to the timeline view, so there's no value in adding the toggle to VS Code.

   @devoncarew @dnfield does that sound correct?

   (The other one - debugCheckElevationsEnabled - does sound useful though)
5. DanTup

   modified the milestones: v2.26.0, On Deck on Apr 18, 2019
6. DanTup commented on Apr 22, 2019

   

   DanTup

   on Apr 22, 2019

   MemberAuthor

   More actions

   Closing this on the assumption it'd be better in DevTools rather than VS Code, since the data only shows up in DevTools. If we decide to put it back, the work is in dc07146 and in case that changeset disappears, is basically the same work that was merged in #1629 but with different names.
7. DanTup

   closed this as completedon Apr 22, 2019
8. DanTup

   removed

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   in flutterRelates to running Flutter appsRelates to running Flutter apps

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Apr 22, 2019