You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update notification is shown even after first install #1633
@Tyriar thanks! I hadn't considered that - we basically just check in the extension context whether we've every shown a notification for the current version. I'll see if I can detect when it's the first run, and if not, just add another flag to track this.
@DanTup 👍 the strategy we've used for this sort of thing is to store the last version the update notification was shown, if that value doesn't exist in local storage that means it's the first run and doesn't need to show
Good idea, that makes more sense than my flag-per-version. I think mine came from already having a "Don't show this again" option in other places that just took a key to store, so I just reused it with the version number 😄
Activity
DanTup commentedon Apr 19, 2019
@Tyriar thanks! I hadn't considered that - we basically just check in the extension context whether we've every shown a notification for the current version. I'll see if I can detect when it's the first run, and if not, just add another flag to track this.
Tyriar commentedon Apr 19, 2019
@DanTup 👍 the strategy we've used for this sort of thing is to store the last version the update notification was shown, if that value doesn't exist in local storage that means it's the first run and doesn't need to show
DanTup commentedon Apr 19, 2019
Good idea, that makes more sense than my flag-per-version. I think mine came from already having a "Don't show this again" option in other places that just took a key to store, so I just reused it with the version number 😄
Thanks!