Allow dart syntax highlighting theming #1688

Activity

1. DanTup commented on May 7, 2019

   

   DanTup

   on May 7, 2019

   Member

   More actions

   Our syntax highlighting is all regex-based using a TextMate grammar (https://github.com/Dart-Code/Dart-Code/blob/master/syntaxes/dart.json) so I don't think this is currently possible (it's also why we have strange quirks like #311) until VS Code gets an API for better colouring (microsoft/vscode#585).
2. DanTup

   added this to the Backlog milestone on May 7, 2019
3. DanTup

   added

   blocked on vs code / lsp / dapRequires a change in VS Code to progressRequires a change in VS Code to progress

   in editorRelates to code editing or language featuresRelates to code editing or language features

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on May 7, 2019
4. DanTup

   added

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Oct 27, 2020
5. DanTup

   modified the milestones: Backlog, On Deck on Oct 27, 2020
6. DanTup

   modified the milestones: On Deck, v3.18.0 on Dec 8, 2020
7. DanTup

   removed

   blocked on vs code / lsp / dapRequires a change in VS Code to progressRequires a change in VS Code to progress

   on Dec 8, 2020
8. DanTup commented on Dec 15, 2020

   

   DanTup

   on Dec 15, 2020

   Member

   More actions

   Fixed by the semantic token work in dart-lang/sdk@cb2ede5.

   In order to get the fix you'll need Dart-Code v3.18.0 (a preview release should be available later today/tomorrow), be using LSP Preview, and have a Dart SDK from after yesterday (the most recent nightly works, and of course the next releases of Dart/Flutter SDKs will include this).

   You can then use a theme that colours semantic tokens, or set them up in your own settings. For example, this sets static variables/properties to be rendered red:

   
9. DanTup

   closed this as completedon Dec 15, 2020
10. DanTup commented on Dec 22, 2020

    

    DanTup

    on Dec 22, 2020

    Member

    More actions

    Due to some last minute issues, support for LSP 3.16 (which supports semantic tokens) won't be included in v3.18, but hopefully v3.19 next month instead.
11. DanTup

    modified the milestones: v3.18.0, v3.19.0 on Dec 22, 2020