Skip to content

Categorise things like SDK paths as machine-specific #1717

Closed

Description

@DanTup

https://code.visualstudio.com/updates/v1_34#_machinespecific-settings

Otherwise we'll get weird issues running on containers because local paths are passed in:

ERR EINVAL: invalid argument, open '/workspaces/vscode-dev-containers/containers/flutter/M:\Coding\Applications\Dart-Code-Logs\insiders.analyzer.txt': Error: EINVAL: invalid argument, open '/workspaces/vscode-dev-containers/containers/flutter/M:\Coding\Applications\Dart-Code-Logs\insiders.analyzer.txt'

Activity

  1. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on May 16, 2019
  2. added this to the v3.1.0 milestone on May 16, 2019
  3. DanTup commented on May 20, 2019

    @DanTup
    MemberAuthor

    This is tricky...

    Machine-specific settings can only be configured for User settings.

    Many of our paths are "window" scoped, so that they can be defined within a project (eg., when you quickly switch SDKs, it's written to the current workspace). Seems like this won't work with machine settings.

    We'll need to decide for each setting whether it's more important that it doesn't sync across machines, or that it can be set at the folder/workspace level.

  4. DanTup commented on May 20, 2019

    @DanTup
    MemberAuthor

    I've opened microsoft/vscode#73985 to see if there's a possibility of better supporting these.

  5. modified the milestones: v3.1.0, On Deck on May 20, 2019
  6. DanTup commented on Sep 3, 2019

    @DanTup
    MemberAuthor

    Insiders now has support for machine-specific overridable settings.

  7. modified the milestones: On Deck, v3.5.0 on Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions