Repository navigation
Improve performance of completions #1750
Description
As well as probably being the cause of #1721, the performance of completions with unimported symbols is generally poor.
Testing on Windows PC with the following test (inside test\flutter_only\providers\completion_item_provider.test.ts):
describe("with SuggestionSet support", () => {
beforeEach("ensure SuggestionSets are supported", function () {
if (!extApi.analyzerCapabilities.supportsAvailableSuggestions)
this.skip();
});
it.only("includes unimported symbols", async () => {
await setTestContent(`
main() {
ProcessInf
}
`);
const count = 50;
const start = Date.now();
for (let i = 0; i < 50; i++) {
const completions = await getCompletionsAt("ProcessInf^");
ensureCompletion(completions, vs.CompletionItemKind.Class, "ProcessInfo", "ProcessInfo");
}
const end = Date.now();
console.log(`Took ${end - start}ms to do ${count} completion requests`);
});
});
Output from a few runs:
Took 56426ms to do 50 completion requests
Took 57034ms to do 50 completion requests
Took 57607ms to do 50 completion requests
Activity
DanTup commentedon May 27, 2019
Some (terrible) figures from the committed test on initial code:
Memory does go back down, so we're probably not leaking, just allocating a lot for every big completion request.
DanTup commentedon May 27, 2019
Without the new completions, numbers are tiny, confirming it's that work that's causing the issues:
DanTup commentedon May 27, 2019
It seems that a lot of this time may be within VS Code for passing the data between the extension host and UI (if we do all the computation but just don't return the results, it goes super fast). I've opened microsoft/vscode#74418 to see if it's possible this could be improved there or not.
DanTup commentedon Jun 19, 2019
Going to close this since a lot of work was done in this version. There's still a branch that has some cleanup that might improve things further, but that's for a future milestone.