Skip to content

Find a faster way to find project folders in the tree #1840

Closed
Closed
Find a faster way to find project folders in the tree#1840
Labels
is performance
Milestone
v3.5.0

Description

@DanTup
DanTup
opened on Jul 8, 2019

Enumerating all the folders seems like it can be slow:

#1819 (comment)

Maybe there's a better way we can do this (eg. get a list of all pubspec.yamls from the FS within the top 3 levels without having to hit the FS so much).

Activity

  1. DanTup
    added
    is performance
    on Jul 8, 2019
  2. DanTup
    added this to the v3.3.0 milestone on Jul 8, 2019
  3. DanTup
    added a commit that references this issue on Jul 9, 2019

    Perf testing...

    2aa32ac

  4. DanTup commented on Jul 9, 2019

    @DanTup
    DanTup
    on Jul 9, 2019
    MemberAuthor

    Tried a few things, but generally they were much worse (on my MacBook Pro at least):

    #1819 (comment)

    (Though the original code only took 100ms here for 1000 projects, which is nothing like the 100ms-per-exists-check seen in the original profile).

  5. DanTup
    modified the milestones: v3.3.0, v3.4.0 on Jul 10, 2019
  6. DanTup
    added a commit that references this issue on Jul 10, 2019

    Perf testing...

    9123cc1
  7. DanTup
    modified the milestones: v3.4.0, v3.5.0 on Aug 28, 2019

  8. DanTup commented on Sep 19, 2019

    @DanTup
    DanTup
    on Sep 19, 2019
    MemberAuthor

    Fixed by #2003.

  9. DanTup
    closed this as completedon Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    is performance

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions