Skip to content

Move debug adapters to run out of process #1876

Closed
Closed
Move debug adapters to run out of process#1876
Labels
in debuggingRelates to the debug adapter or process of running debug sessionsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
Milestone
v3.14.0

Description

@DanTup
DanTup
opened on Jul 18, 2019

We can now return a DebugAdapterExecutable from provideDebugAdapter that will allow us to run out debug adapters out-of-process again, but still pick a different one based on project type:

https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_28.md#debug-api-1
microsoft/vscode#59107

This will remove any possibility of us leaking memory in debug sessions that could affect the extension host and prevent us accidentally sharing state between the two (which we currently do, like with globalFlutterArgs).

  • re-enable the lint in lints/disallowImportingNonSharedCodeRule.js when DAs run out-of-process

Activity

  1. DanTup
    added
    is non-functional
    in debuggingRelates to the debug adapter or process of running debug sessions
    on Jul 18, 2019
  2. DanTup
    added this to the v3.4.0 milestone on Jul 18, 2019
  3. DanTup
    modified the milestones: v3.4.0, v3.5.0 on Aug 26, 2019
  4. DanTup
    modified the milestones: v3.5.0, v3.6.0 on Oct 1, 2019
  5. DanTup
    modified the milestones: v3.6.0, v3.7.0 on Oct 17, 2019
  6. DanTup
    modified the milestones: v3.7.0, v3.8.0 on Nov 19, 2019
  7. DanTup
    modified the milestones: v3.8.0, v3.9.0 on Jan 2, 2020
  8. DanTup
    added a commit that references this issue on Feb 3, 2020

    Remove some extension dependencies from debug adapter

    7970612
  9. DanTup
    modified the milestones: v3.9.0, On Deck on Mar 11, 2020
  10. DanTup
    modified the milestones: On Deck, v3.14.0 on Aug 7, 2020
  11. DanTup
    added a commit that references this issue on Aug 7, 2020

    Switch debug adapters to run back out-of-process

    77bb68d
  12. DanTup
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    and removed
    is non-functional
    on Aug 7, 2020
  13. DanTup
    added 2 commits that reference this issue on Aug 10, 2020

    Switch debug adapters to run back out-of-process

    bbe6af4

    Switch debug adapters to run back out-of-process

    b520ef0
  14. DanTup
    closed this as completedin 0b65a03on Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions