Repository navigation
Missing code actions for refactoring key binds #1931
Description
The keybinding below worked well until recently. Now it displays a "No code actions available" message.
{
"key": "cmd+. w",
"command": "editor.action.codeAction",
"args": {
"kind": "refactor.flutter.wrap.generic"
},
"when": "editorLangId == 'dart' && dart-code:anyFlutterProjectLoaded && editorHasCodeActionsProvider && editorTextFocus && !editorReadonly"
}
Activity
DanTup commentedon Aug 19, 2019
Do the code actions appear in the normal editor list (eg. with
Cmd+.)? This sounds a bit like #1926 which I can't reproduce. Could you provide the info asked for here?marko commentedon Aug 19, 2019
They appear and work in the normal list.
Flutter 1.9.0
VS Code 1.37.1
Dart Code 3.3.0
No errors in console
DanTup commentedon Aug 19, 2019
Ok, not the same. I can reproduce however. W're definitely returning matching code actions:
But they don't show up in the list... I'll do some digging.
DanTup commentedon Aug 19, 2019
This looks like a VS Code bug to me, so I've opened microsoft/vscode#79455 with a repro hoping for some input.
DanTup commentedon Aug 20, 2019
This turned out to be my bug... There's filtering in code actions (to avoid requesting unrelated code actions) but it didn't correctly handle when the filter was a sub-kind of Refactor (eg. when VS Code asked for
refactors it worked, but when asked forrefactor.fooit did not.