Skip to content

Switch to --dump-service-info from scraping stdout #2148

Closed
#2313
#2304
Closed
Switch to --dump-service-info from scraping stdout#2148
#2313
#2304
Labels
in dartRelates to running Dart programsin debuggingRelates to the debug adapter or process of running debug sessionsis non-functional
Milestone
v3.9.0

Description

@DanTup
DanTup
opened on Dec 5, 2019

We currently scrape a header from stdout to find the Observatory URL (and suppress it from going to the debug console). We should instead use --dump-service-info (for VMs that are a high enough version that support it).

dart-lang/sdk#38418

Activity

  1. DanTup
    added
    is non-functional
    in debuggingRelates to the debug adapter or process of running debug sessions
    in dartRelates to running Dart programs
    on Dec 5, 2019
  2. DanTup
    added this to the v3.8.0 milestone on Dec 5, 2019
  3. DanTup
    modified the milestones: v3.8.0, v3.9.0 on Jan 2, 2020

  4. DanTup commented on Feb 13, 2020

    @DanTup
    DanTup
    on Feb 13, 2020
    MemberAuthor

    Also use -DSILENT_OBSERVATORY=true to stop the banner showing up.

  5. DanTup
    added a commit that references this issue on Mar 17, 2020

    Use write-service-info to get Observatory URI instead of relying on s…

    cbfe270
  6. DanTup
    closed this as completedin #2304on Mar 23, 2020
  7. DanTup
    added a commit that references this issue on Mar 23, 2020

    Use write-service-info to get Observatory URI instead of relying on s…

    9575b08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in dartRelates to running Dart programsin debuggingRelates to the debug adapter or process of running debug sessionsis non-functional

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions