Skip to content

Not detecting the scope variable #2237

Closed

Description

@daniel-scatigno

After inspecting the scope, the extension did not detected the variable, instead it detected as generic "source.dart"
I think it should have been detected as "variable.name.source.dart"

image

Activity

  1. DanTup commented on Jan 28, 2020

    @DanTup
    Member

    I think this may be solved by #2203, which is work to move from the TextMate grammar file to using semantic info from the analysis server directly (this will make it more accurate and solve a couple of bugs we have).

    Finishing/merging the work requires VS Code finalizing (and shipping) the API which seems to be assigned to the February release.

  2. added this to the v3.9.0 milestone on Jan 28, 2020
  3. modified the milestones: v3.9.0, On Deck on Mar 11, 2020
  4. modified the milestones: On Deck, Backlog on Jul 2, 2020
  5. modified the milestones: On Deck, v3.18.0 on Dec 10, 2020
  6. DanTup commented on Dec 15, 2020

    @DanTup
    Member

    With the semantic token work in dart-lang/sdk@cb2ede5 you'll now be able to theme using semantic tokens instead, which will produce more reliable tokens. In the example above, there will be a property token with the declaration modifier for itemSuggestions.

    In order to get the fix you'll need Dart-Code v3.18.0 (a preview release should be available later today/tomorrow), be using LSP Preview, and have a Dart SDK from after yesterday (the most recent nightly works, and of course the next releases of Dart/Flutter SDKs will include this).

  7. modified the milestones: v3.18.0, v3.19.0 on Dec 22, 2020
  8. DanTup commented on Dec 22, 2020

    @DanTup
    Member

    Due to some last minute issues, support for LSP 3.16 (which supports semantic tokens) won't be included in v3.18, but hopefully the next release after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions