Skip to content

Support (as a preview option) using the LSP protocol for analysis server communications #2238

Closed

Description

@vogella

In Eclipse L4P4E I see the following log messages:

[t=1580217833406] LSP4E to org.eclipse.dartboard.server:
{"jsonrpc":"2.0","id":"37","method":"textDocument/completion","params":{"textDocument":

The logging in Dartcode seems not to be logging the language server communication but the analysis server:

3:03:38 PM] [Analyzer] [Info] <== {"event":"completion.availableSuggestions",

Is is planned to move the logging to LSP based communication.

Activity

  1. DanTup commented on Jan 28, 2020

    @DanTup
    Member

    Right now the Dart extension doesn't use LSP. What you're seeing logged is the original analysis server protocol (pre-LSP). It should essentially have the same contents, just in a different form (though completions are a bit tricky, since availableSuggestions are a way to preload them into the editor for performance reasons).

    There is ongoing work to migrate to LSP (currently only on the lsp branch here) and as part of that, the logging would show LSP traffic instead of the original JSON protocol. I'm hoping to merge it soon (probably sometime in Feb) so that it would available for testing (though there are still some rough edges or unimplemented functionality).

    I don't think there's actually an issue for this work (there is a project here) so I'll rename this one slightly for it.

  2. changed the title [-]Capture Logs via DartCode does not show language server protocol messages[/-] [+]Support (as a preview option) using the LSP protocol for analysis server communications[/+] on Jan 28, 2020
  3. added this to the v3.9.0 milestone on Jan 28, 2020
  4. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in editorRelates to code editing or language features
    on Jan 28, 2020
  5. bsutton commented on Oct 21, 2020

    @bsutton

    I don't believe so. I've just uninstalled flutter/dart-code and then re-installed the standard flutter extension from the market place which re-installed dart-code.

    The same problem persists.

  6. DanTup commented on Oct 22, 2020

    @DanTup
    Member

    @bsutton was that comment intended for another issue?

  7. bsutton commented on Oct 22, 2020

    @bsutton

    Sorry yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions