Repository navigation
LSP Known Issues #2286
Description
When running in LSP mode, the following things are known not to work (or function differently to non-LSP):
Running "Dart: Sort Members" command failsWidget UI Guides don't workSupport Flutter UI Guides in LSP #2425Gutter Icons don't workSupport Gutter Icons in LSP #2426Thewontfixdart.doNotFormatsetting used to exclude files/folders from auto-formatting does not workTheSupport the "dart.analysisExcludedFolders" setting in LSP #2680dart.analysisExcludedFolderssetting does not exclude folders from analysisThedart.enableSdkFormattersetting does not unregister the formatterAnalysis server plugins do not workFind implementations only works on the method namewontfixRename does not work on thewontfiximportorclasskeywords- Refactor: Extract local variable is not available Support "Extract Local Variable" in LSP #2951
Refactor: Extract method is not availableRefactor: Extract widget is not available- Moving/renaming files do not update references Imports are not updated when moving/renaming files when using LSP #2761
- No options for including parens/args in completion LSP code completion should have an option to include parens and/or args #2823
Activity
Skip tests in LSP mode for things known not to work
Skip tests in LSP mode for things known not to work
Skip tests in LSP mode for things known not to work
ericdallo commentedon Apr 24, 2020
@DanTup I'm implementing the Emacs support for dart/flutter on lsp-dart so I'm checking how you did it on this extension and notice the problems above :)
DanTup commentedon May 4, 2020
@ericdallo thanks! I've added UI Guides to the list above. CodeLens is supposed to work, though I can see it failing so I've opened #2421 - probably will be an easy fix. Thanks!
ericdallo commentedon May 4, 2020
I implemented the both features on lsp-dart, so I think it's easy to fix them on the vscode extension :)
DanTup commentedon May 5, 2020
@ericdallo actually, the reason my code lens didn't work is that I was using an older Dart SDK that wasn't sending the outline notifications. On the most recent nightly the code lens seem to work fine. Do you know what version you were using when you saw it fail?
ericdallo commentedon May 5, 2020
Yeah, me too 😅 I was using dart dev
2.8.0-10DanTup commentedon May 5, 2020
Ok great, working as expected then :-) I've fixed up Flutter UI Guides and Gutter icons too.
ericdallo commentedon May 5, 2020
Nice! just a thing to keep in mind, If the next features could be implemented for LSP too, I could implement it on
lsp-dart:)Thanks!
DanTup commentedon May 5, 2020
@ericdallo do you mean specific features, or just in general? Any new features being implemented are very likely to be added to LSP too (some may even only be implemented in LSP) as I'd like to switch Dart-Code over to LSP by default (without losing any significant functionality).
Some of the things mentioned above (like
dart.analysisExcludedFoldersanddart.doNotFormat) are kinda hacks though, so they might not be carried over (or may be reworked if they are).ericdallo commentedon May 5, 2020
Nice, good to know!
That's what I wanted to hear, I was afraid that DAS was the focus for new features, not LSP
7 remaining items
Allow dart.lineLength to control formatting for LSP
Kavantix commentedon Jul 15, 2020
I enabled the log file but it stays empty (other than the versions I am using)
Here is a gif showing the issue:
DanTup commentedon Jul 15, 2020
@Kavantix I reproduced this with Dart 2.8.2 but couldn't reproduce on the current code to try and debug. Could you temporarily try with the latest nightly SDK from http://gsdview.appspot.com/dart-archive/channels/be/raw/latest/sdk/ to see if it still happens for you there?
That doesn't sound right - though VS Code sometimes doesn't update files that are modified correctly unless you close/re-open them - could it be that? Also - can you check you used
dart.analyzerLogFileand notdart.analyzerInstrumentationLogFile? Thanks!RaviKavaiya commentedon Jul 18, 2020
@DanTup I am using latest beta version of DartCode in LSP mode. How can I set custom line length?
Kavantix commentedon Jul 18, 2020
@DanTup Also happens with the last version:
It did however now write some info to the log file
dartlog_import_issue.txt
Btw I was checking the log file using
tail -ffrom the command line ;)DanTup commentedon Jul 18, 2020
@RaviKavaiya
This fix is in the server, so you need an updated Dart SDK (such as a nightly from http://gsdview.appspot.com/dart-archive/channels/be/raw/latest/sdk/). It should then use the same
dart.lineLengthsetting that the non-LSP implementation uses.@Kavantix
Thanks - I also managed to hit this again yesterday in the nightly, so it is still there. I'll do some more digging, thanks!
RaviKavaiya commentedon Jul 18, 2020
@DanTup Sorry, I don't know whether I should ask that here. But, Flutter doesn't allow custom Dart SDKs right? If yes, then I would wait for it. (BTW, I am on Flutter Dev channel)
DanTup commentedon Jul 18, 2020
@RaviKavaiya correct - for Flutter you need to use the SDK it provides. When you run
flutter --versionit will show the version of the SDK (eg.Dart 2.9.0 (build 2.9.0-21.0.dev 89fe12b12a)) so once that's higher than the version that includes this change it should work.DanTup commentedon Jul 20, 2020
@Kavantix I got to the bottom of the issue - I've got a fix out for review at https://dart-review.googlesource.com/c/sdk/+/154960/. Thanks!
Fix modifications stamps for modified files
Kavantix commentedon Jul 21, 2020
@DanTup I can confirm that the fix works, Thanks a lot this will save me quite some headaches using the LSP in vim :)
DanTup commentedon Jul 21, 2020
@Kavantix excellent, thanks for confirming!
DanTup commentedon Nov 11, 2020
Most of the issue here are resolved. There are a few outstanding which have their own issues (which I've linked in the description above), which I'm hoping to address fairly soon so that LSP can become the default.
If you encounter any other issues not listed, please file new specific issues. Thanks!