You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Symbols are doubled in VSCode's cmd+shift+O outline popover if additionalAnalyzerFileExtensions includes Dart/duplicates #2323
changed the title [-]Symbols are doubled in VSCode's cmd+R popover[/-][+]Symbols are doubled in VSCode's cmd+shift+O outline popover[/+]on Mar 27, 2020
I did - one with flutter_tools and flutter_test in it. If you can reliably repro in Stable and not in Insiders, then it doesn't sound like it could be a VS Code bug (so not sure why C++ did an extension update to fix it).
Happy to do some digging if you can make a small repro though to be sure. Thanks!
This is happening to me consistently when opening any two or more Dart projects. I just tried across a variety of input, and symbols double up regardless.
Next, I disabled all of my installed extensions, except for Dart and Flutter. The issue persists.
Weird, not sure why I don't see it. Can you reproduce in a really simple project like a new flutter create project? And could you capture a log for this (with Dart: Capture Logs) for me to review?
I decided to see if anything stood out in my settings as potentially being related, and noticed that I had dart.additionalAnalyzerFileExtensions set with one of the extensions as...dart.
Removing it solved the issue. 😳
Sorry for the false alarm. I was working on an analyzer plugin a few weeks back and was poking at things to see how they worked.
Good catch! This is a bug - I think it's causing us to register the provider twice (once for the hard-coded Dart, and once for the one you added), which means VS Code is asking both for results and concatenating them.
Even though this shouldn't be common, we should fix this. Thanks!
changed the title [-]Symbols are doubled in VSCode's cmd+shift+O outline popover[/-][+]Symbols are doubled in VSCode's cmd+shift+O outline popover if additionalAnalyzerFileExtensions includes Dart/duplicates[/+]on Mar 31, 2020
Activity
shyndman commentedon Mar 27, 2020
Ah, it could very well be related to this: microsoft/vscode-cpptools#4445
I am using a multi-root workspace. I'm going to try out their insiders build.
[-]Symbols are doubled in VSCode's cmd+R popover[/-][+]Symbols are doubled in VSCode's cmd+shift+O outline popover[/+]shyndman commentedon Mar 27, 2020
Yes, insiders fixes this. I'm closing this off.
DanTup commentedon Mar 30, 2020
Hmm, interesting - that issue looks like i's describing an insiders version of the C++ extension, not VS Code? I wouldn't expect that to affect this.
If you manage to repro this again, please let me know!
shyndman commentedon Mar 30, 2020
You tried with a multi-root workspace? Happens every time for me. Never with Insiders.
It sounds like it's being encountered with C++, but is related to the multi-root workspace.
DanTup commentedon Mar 30, 2020
I did - one with flutter_tools and flutter_test in it. If you can reliably repro in Stable and not in Insiders, then it doesn't sound like it could be a VS Code bug (so not sure why C++ did an extension update to fix it).
Happy to do some digging if you can make a small repro though to be sure. Thanks!
shyndman commentedon Mar 30, 2020
This is happening to me consistently when opening any two or more Dart projects. I just tried across a variety of input, and symbols double up regardless.
Next, I disabled all of my installed extensions, except for Dart and Flutter. The issue persists.
Thoughts?
shyndman commentedon Mar 30, 2020
Ah, interesting. Happens outside of multi-root projects too. Any Dart project is displaying this behaviour.
DanTup commentedon Mar 31, 2020
Weird, not sure why I don't see it. Can you reproduce in a really simple project like a new
flutter createproject? And could you capture a log for this (with Dart: Capture Logs) for me to review?shyndman commentedon Mar 31, 2020
Here you go. What I did:
code DartCode_double_symbolsResult:
Dart-Code-Log-2020-02-02 09-26-41.txt
shyndman commentedon Mar 31, 2020
I decided to see if anything stood out in my settings as potentially being related, and noticed that I had
dart.additionalAnalyzerFileExtensionsset with one of the extensions as...dart.Removing it solved the issue. 😳
Sorry for the false alarm. I was working on an analyzer plugin a few weeks back and was poking at things to see how they worked.
DanTup commentedon Mar 31, 2020
Good catch! This is a bug - I think it's causing us to register the provider twice (once for the hard-coded Dart, and once for the one you added), which means VS Code is asking both for results and concatenating them.
Even though this shouldn't be common, we should fix this. Thanks!
[-]Symbols are doubled in VSCode's cmd+shift+O outline popover[/-][+]Symbols are doubled in VSCode's cmd+shift+O outline popover if additionalAnalyzerFileExtensions includes Dart/duplicates[/+]DanTup commentedon Mar 31, 2020
We should probably distinct the whole list, so if you also added another extension to the list multiple times, it wouldn't cause the same thing.