You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think the method I'm using is the correct one; since it doesn't show all the things inside a class (I guess the clue was in the name, "top level").
I think this is the best analyzer API to use, to map to the symbol search. We may still want the API extended to show more things (Foo.ba would show something like Foo.bar).
Do you think it's worthwhile me sending two requests (as mentioned here) in the meantime? I think Code users would probably expect class methods/properties to appear in the search and it feels a bit limited as it is.
findMemberDeclarations looks very similar to the one I'm currently using; it's just global search for declerations with that name (though it might only do full matches and no pattern). I might have a go at merging results from both and see how it feels; certainly the current behaviour doesn't feel as useful as I would expect. I guess I could also compare results with some sample code on both TS and Dart.
@devoncarew I've implemented merging of these two for now. Seems to work ok for me (though I discovered a crazy bug in the process - microsoft/vscode#10446) but if you have a minute to test it I'd be interested in your opinion.
It works more like Ctrl+T for TypeScript now (eg. it'll include things from your imported packages, etc.). I think it might be both more and less useful at the same time.
I have not yet put any wildcard characters in (as suggested by @bwilkersonhere) because it seems to already return things that start with what I pass (and I'm concerned when it gets fixed it'll just break and come less useful).
I'm planning on pushing a release out tomorrow. I might try and get #53 in first; I think it'll help me as a Dart noob (I keep meaning to sit down and actually try to write something real in Dart in it but it hasn't happened yet!).
Going to consider this done for now; I think it's the best we can do. If the AS gets a new API in an upcoming version, I'll switch to it (though need to consider what to do if an old SDK is being used - something I've ignored for now... who knows what this thing does with an old SDK AS)...
Activity
[-]Search doesn't list expected items[/-][+]Syymbol search doesn't list expected items[/+][-]Syymbol search doesn't list expected items[/-][+]Symbol search doesn't list expected items[/+]devoncarew commentedon Aug 6, 2016
I think this is the best analyzer API to use, to map to the symbol search. We may still want the API extended to show more things (
Foo.bawould show something likeFoo.bar).DanTup commentedon Aug 6, 2016
Do you think it's worthwhile me sending two requests (as mentioned here) in the meantime? I think Code users would probably expect class methods/properties to appear in the search and it feels a bit limited as it is.
devoncarew commentedon Aug 6, 2016
I haven't used the other APIs - are they used for searching for a member
given a class? Or for any member in a project?
There's a separate vscode api for symbols within a file. That may make the
most sense to map to the analyzers outline api.
DanTup commentedon Aug 6, 2016
findMemberDeclarations looks very similar to the one I'm currently using; it's just global search for declerations with that name (though it might only do full matches and no pattern). I might have a go at merging results from both and see how it feels; certainly the current behaviour doesn't feel as useful as I would expect. I guess I could also compare results with some sample code on both TS and Dart.
devoncarew commentedon Aug 6, 2016
/cc @bwilkerson @scheglov
DanTup commentedon Aug 7, 2016
I did also post to analyzer-discuss if it's more helpful for others if the discussion happens there.
Merge topLevelDeclerations and findMemberDeclerations for workspace s…
DanTup commentedon Aug 11, 2016
@devoncarew I've implemented merging of these two for now. Seems to work ok for me (though I discovered a crazy bug in the process - microsoft/vscode#10446) but if you have a minute to test it I'd be interested in your opinion.
It works more like
Ctrl+Tfor TypeScript now (eg. it'll include things from your imported packages, etc.). I think it might be both more and less useful at the same time.I have not yet put any wildcard characters in (as suggested by @bwilkerson here) because it seems to already return things that start with what I pass (and I'm concerned when it gets fixed it'll just break and come less useful).
devoncarew commentedon Aug 11, 2016
Awesome! I'll will give it a shot; I'm set up for development on my machine at home; also looking forward to the next release :)
DanTup commentedon Aug 11, 2016
I'm planning on pushing a release out tomorrow. I might try and get #53 in first; I think it'll help me as a Dart noob (I keep meaning to sit down and actually try to write something real in Dart in it but it hasn't happened yet!).
DanTup commentedon Aug 12, 2016
Going to consider this done for now; I think it's the best we can do. If the AS gets a new API in an upcoming version, I'll switch to it (though need to consider what to do if an old SDK is being used - something I've ignored for now... who knows what this thing does with an old SDK AS)...