You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
For web apps, Web-Server is picked over Chrome by default #2453
Not sure if this changed recently, but for web apps when there's only Chrome + Web Server, it seems to default to Web Server which is not what most people want.
We can handle this with an exclusion in Dart-Code, though I wonder if it's worth addressing in Flutter. We currently have an ephemeral boolean that lets us prefer devices that are explicitly connected, but maybe there should also (or instead) be a priority, and we only switch if the newly connected device is >= the priority of the current device? (@jonahwilliams)
When the first device comes through (web-server), we select it because we don't have any other device. When the second device (Chrome) comes through, we do not select it because we already have a selected device and the new device is not marked ephemeral.
I've put specific handling in here for allowing Chrome to override Web-Server when it's added. If we get something better in Flutter, I can remove it in future - but since a Flutter stable release with any change is likely some way off, having it in the next release here seems worthwhile.
Activity
jonahwilliams commentedon May 13, 2020
Is the order of returned devices used? It's not great, but I can document and test this
DanTup commentedon May 13, 2020
Yeah, right now they come through in this order:
When the first device comes through (web-server), we select it because we don't have any other device. When the second device (Chrome) comes through, we do not select it because we already have a selected device and the new device is not marked ephemeral.
DanTup commentedon May 13, 2020
I've put specific handling in here for allowing Chrome to override Web-Server when it's added. If we get something better in Flutter, I can remove it in future - but since a Flutter stable release with any change is likely some way off, having it in the next release here seems worthwhile.