Unrelated code shown when pressing Command over symbol #2653

Activity

1. DanTup

   added

   is bug

   in editorRelates to code editing or language featuresRelates to code editing or language features

   on Jul 20, 2020
2. DanTup

   added this to the v3.13.0 milestone on Jul 20, 2020
3. DanTup

   changed the title [-]Unrelated code shown when pressing Shift+Option over symbol[/-] [+]Unrelated code shown when pressing Command over symbol[/+] on Jul 28, 2020
4. DanTup commented on Jul 28, 2020

   

   DanTup

   on Jul 28, 2020

   MemberAuthor

   More actions

   This might be because we're not returning one of the data types with the extra ranges on:

   https://microsoft.github.io/language-server-protocol/specifications/specification-current/#locationLink
5. DanTup

   modified the milestones: v3.13.0, v3.14.0 on Jul 28, 2020
6. DanTup

   added

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Aug 4, 2020
7. DanTup commented on Aug 10, 2020

   

   DanTup

   on Aug 10, 2020

   Last edited by DanTup

   MemberAuthor

   More actions

   I've got an SDK branch (lsp-def-code-offset-new) that supplies this, but I've hit two issues:

   1. VS Code seems to use the opposite range to what I'd expect: Holding Cmd while hovering a symbol shows LocationLink's "targetSelectionRange" instead of "selectionRange" as preview microsoft/vscode#104369
   2. codeOffset/codeLength is missing from the element for "add" in the example above (though it's present for "Icons")
8. DanTup

   added

   blocked on dart / flutterRequires a change in Dart or Flutter to progressRequires a change in Dart or Flutter to progress

   blocked on vs code / lsp / dapRequires a change in VS Code to progressRequires a change in VS Code to progress

   on Aug 10, 2020
9. DanTup

   modified the milestones: v3.14.0, On Deck on Aug 10, 2020
10. DanTup

    modified the milestones: On Deck, v3.16.0 on Oct 1, 2020
11. DanTup

    removed

    blocked on vs code / lsp / dapRequires a change in VS Code to progressRequires a change in VS Code to progress

    on Oct 26, 2020
12. DanTup

    modified the milestones: v3.16.0, v3.17.0 on Oct 26, 2020
13. DanTup commented on Oct 26, 2020

    

    DanTup

    on Oct 26, 2020

    MemberAuthor

    More actions

    The LSP server side of this is done, but this requires moving to an updated LSP client library that hasn't been published yet:

    microsoft/vscode#104369

    We could consider using the pre-release version in the meantime.
14. DanTup

    closed this as completedin 0c9f01con Nov 3, 2020
15. DanTup commented on Dec 10, 2020

    

    DanTup

    on Dec 10, 2020

    MemberAuthor

    More actions

    Using this pre-release package has introduced an issue when using LSP against the server built for v3.16 so this needs to be reverted.
16. DanTup

    reopened this on Dec 10, 2020
17. DanTup

    modified the milestones: v3.17.0, v3.18.0 on Dec 10, 2020
18. DanTup

    removed

    blocked on dart / flutterRequires a change in Dart or Flutter to progressRequires a change in Dart or Flutter to progress

    on Dec 10, 2020
19. DanTup commented on Dec 10, 2020

    

    DanTup

    on Dec 10, 2020

    MemberAuthor

    More actions

    This is re-broken in v3.17.1 to fix #3001, and re-fixed in v3.18.0.
20. DanTup

    closed this as completedon Dec 10, 2020
21. DanTup

    modified the milestones: v3.18.0, v3.19.0 on Dec 22, 2020
22. DanTup commented on Dec 22, 2020

    

    DanTup

    on Dec 22, 2020

    MemberAuthor

    More actions

    Bumping to v3.19 as this relies on the updated LSP client.