Convert quotes quick-fix does not appear to interpolated strings #2727

Activity

1. DanTup commented on Aug 24, 2020

   

   DanTup

   on Aug 24, 2020

   Member

   More actions

   I'm unable to repro this, I have a "Convert to relative" fix when I set this up as you describe above:

   

   Could you try to reproduce this with a new project created with Flutter: New Project and if it repros, attach a zip of the whole folder (including the hidden items like .packages and .dart_tool)? Thanks!
2. DanTup

   added

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Aug 24, 2020
3. bsutton commented on Aug 25, 2020

   

   bsutton

   on Aug 25, 2020

   More actions

   I'm also seeing this problem.
4. bsutton commented on Aug 26, 2020

   

   bsutton

   on Aug 26, 2020

   More actions

   I've also just noticed that the quick fix to convert a line from double to single quotes is also missing.
5. DanTup commented on Aug 26, 2020

   

   DanTup

   on Aug 26, 2020

   Member

   More actions

   Could you try to reproduce this with a new project created with Flutter: New Project and if it repros, attach a zip of the whole folder (including the hidden items like .packages and .dart_tool)?

   Also - could you confirm your SDK version + whether dart.previewLsp is enabled or not? Thanks!
6. bsutton commented on Aug 27, 2020

   

   bsutton

   on Aug 27, 2020

   More actions

   I just created a new project using Flutter: New Project.

   The quick change for strings works for a new project.
7. DanTup commented on Aug 27, 2020

   

   DanTup

   on Aug 27, 2020

   Member

   More actions

   If you copy your analysis_options.yaml over to the new project, does that break it? If not, are you able to try trimming down the project where this happens to something you can share? Thanks!
8. bsutton commented on Sep 1, 2020

   

   bsutton

   on Sep 1, 2020

   More actions

   This project exhibits the problem with tip 'convert to single quotes' missing.
   dscript.zip
9. DanTup commented on Sep 1, 2020

   

   DanTup

   on Sep 1, 2020

   Member

   More actions

   Perfect, thanks! I was able to reduce it to just this:

   void main(List<String> args) {
     var server = "foo";
   
     print("Using: $server");
   }

   The fix is appearing on the first string, but missing on the interpolated string. There are tests that seem to do exactly the same thing so I'm trying to figure out what's different (in this case, the fix producer is ending up with the print token, and therefore produces no fix).
10. DanTup

    added

    in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

    is bug

    and removed

    awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

    on Sep 1, 2020
11. DanTup

    added this to the v3.15.0 milestone on Sep 1, 2020
12. bsutton commented on Sep 1, 2020

    

    bsutton

    on Sep 1, 2020

    More actions

    Yes, I concur that its just on interpolated strings.
13. DanTup commented on Sep 1, 2020

    

    DanTup

    on Sep 1, 2020

    Member

    More actions

    I've got a potential fix at https://dart-review.googlesource.com/c/sdk/+/161171/.
14. dart-bot

    added a commit that references this issue on Sep 1, 2020

    [Analyzer] Fix convert_to_single_quotes fix for interpolated strings

    ...

    fb0729b
15. DanTup commented on Sep 22, 2020

    

    DanTup

    on Sep 22, 2020

    Member

    More actions

    Fixed by dart-lang/sdk@fb0729b.
16. DanTup

    closed this as completedon Sep 22, 2020
17. DanTup

    changed the title [-]Quick fix does not offer anymore a fix for "Prefer relative imports for files in `lib/`." problems[/-] [+]Convert quotes quick-fix does not appear to interpolated strings[/+] on Sep 24, 2020