You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Stack traces in test errors are not linkified #2794
With this and #2795 fixed, it now looks like this:
We can't currently map dart:async anywhere so it remains in the message on the left (we can't attach a link that would appear on the right), but I think it's an improvement (ignoring the not-so-friendly async stack traces, but that's not something we can improve in the extension).
@DanTup I installed the v3.15 beta vsix, both reloaded and then restarted vsc for good measure but when running tests I still don't seem to see the test failure relative stack traces being linked?
@maks oh, that's a different place again. In the original screenshot it was the Debug Console (which we parse the output for and attach location metadata). The other one was the Terminal (where we now detect package: links with a regex, and VS Code does the path links). This one is the Output Pane (which we show if you click back on a test node in the tree). As far as I know, there's no way for us to provide links there (though I think in theory the link provider code would work there if we had a hook - @Tyriar does that seem like a useful feature request?).
I wonder if we could switch to using a pseudo terminal for those results now instead of an Output pane. That would probably get VS Code's normal linking (which I presume includes relative paths) as well as our link provider (for package: paths). I've opened #2825 to have a look at that.
Activity
DanTup commentedon Sep 15, 2020
With this and #2795 fixed, it now looks like this:
We can't currently map
dart:asyncanywhere so it remains in the message on the left (we can't attach a link that would appear on the right), but I think it's an improvement (ignoring the not-so-friendly async stack traces, but that's not something we can improve in the extension).Add stack frame parsing to test error output
Handle relative paths in stack frame parsing
maks commentedon Sep 16, 2020
That's awesome @DanTup - thank you for fixing this so quickly! 👍
Handle relative paths in stack frame parsing
maks commentedon Sep 28, 2020
@DanTup I installed the v3.15 beta vsix, both reloaded and then restarted vsc for good measure but when running tests I still don't seem to see the test failure relative stack traces being linked?
DanTup commentedon Sep 28, 2020
@maks oh, that's a different place again. In the original screenshot it was the Debug Console (which we parse the output for and attach location metadata). The other one was the Terminal (where we now detect package: links with a regex, and VS Code does the path links). This one is the Output Pane (which we show if you click back on a test node in the tree). As far as I know, there's no way for us to provide links there (though I think in theory the link provider code would work there if we had a hook - @Tyriar does that seem like a useful feature request?).
I wonder if we could switch to using a pseudo terminal for those results now instead of an Output pane. That would probably get VS Code's normal linking (which I presume includes relative paths) as well as our link provider (for
package:paths). I've opened #2825 to have a look at that.Tyriar commentedon Nov 6, 2020
There's been some talk of sharing terminal link logic with the output panel: microsoft/vscode#107314, microsoft/vscode#53922