Skip to content

Add a DefinitionProvider to support Go-To Definition #28

Closed

Description

@devoncarew

To support jump to definition.

Activity

  1. added this to the milestone on Aug 6, 2016
  2. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on Aug 6, 2016
  3. changed the title [-]add a DefinitionProvider[/-] [+]Add a DefinitionProvider to support Go-To Definition[/+] on Aug 6, 2016
  4. DanTup commented on Aug 6, 2016

    @DanTup
    Member
  5. DanTup commented on Aug 6, 2016

    @DanTup
    Member

    This is done, but I can't make it work for SDK files so I've raised #35 to add that once I figured it out (the problem seems to be no startLine/startColumn for SDK files).

  6. devoncarew commented on Aug 6, 2016

    @devoncarew
    ContributorAuthor

    IIRC the data for this is sent via notifications (analysis.navigation) so I'll need to keep hold of all of that data somewhere for when it's needed?

    Navigation can come in as events, or as an explicit call, but looks like you found analysis.getNavigation already :)

  7. devoncarew commented on Aug 6, 2016

    @devoncarew
    ContributorAuthor

    Re: that bug, that's probably due to some summary work - the SDK analysis is summarized and stored on disk, instead of being analyzed for each project.

  8. DanTup commented on Aug 6, 2016

    @DanTup
    Member

    Ok, I've just filtered them out for now and I'll deal with it in #35 if/when there's a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions