Repository navigation
Incorrect override code generated when choices contain commas #2813
Description
Originally raised at dart-lang/sdk#43460 by @jensjoha.
"Create missing overrides" when using DAS creates bad code here:
abstract class Foo<E, F> {
E hello(Foo<E, F> x);
}
class Bar implements Foo<String, String> {
}The cause is commas in the choices:
[12:44:34 PM] [General] [Info] Calling insertSnippet with:
${1|Foo<String, String>,Object|} ${2:x}
These should be escaped somewhere.
Activity
DanTup commentedon Sep 22, 2020
It appears that VS Code doesn't escape the commas here (microsoft/vscode#107220), so I'll switch back to adding these manually for now.
jensjoha commentedon Sep 22, 2020
From https://vscode.readthedocs.io/en/latest/editor/userdefinedsnippets/ (which, I suppose, talk about something slightly different)
Update: Nevermind =)
DanTup commentedon Sep 22, 2020
Yep, I've reverted to building these manually and escaping them (c6e01c4). If I just encode them and use
appendChoiceit'll become over-encoded if VS Code fixes the issue, so I'll leave it like this until it's fixed.Thanks!