Allow hiding DevTools buttons from debug toolbar #2836

Activity

1. themisir

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Sep 30, 2020
2. DanTup commented on Sep 30, 2020

   

   DanTup

   on Sep 30, 2020

   Member

   More actions

   Does leaving the button cause any issues? I don't think it's worthwhile introducing a setting to control the visibility of this if it's purely just visual.
3. DanTup

   added

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Sep 30, 2020
4. themisir commented on Sep 30, 2020

   

   themisir

   on Sep 30, 2020

   Author

   More actions

   Does leaving the button cause any issues? I don't think it's worthwhile introducing a setting to control the visibility of this if it's purely just visual.

   No it doesn't causes any issue. It's just visual but, I'm using docked toolbar and it takes a bit too much space.

   
5. DanTup commented on Oct 6, 2020

   

   DanTup

   on Oct 6, 2020

   Member

   More actions

   When using the toolbar docked, you can resize the side bar and it will just hide the additional buttons:

   

   It does first overlap the "Run" text, but this is only while you're in a debug session. I'm not sure it's worth adding an additional setting only for this.
6. themisir commented on Oct 7, 2020

   

   themisir

   on Oct 7, 2020

   Author

   More actions

   Nevermind. Just asked if it's possible to disable.

   I'm not sure it's worth adding an additional setting only for this.

   Anyways adding a setting for enabling/disabling additional feature that modifies editors default behavior (UI in that case) is not unnecessary.

   I would contribute this feature if maintainers would allow.
7. DanTup commented on Oct 7, 2020

   

   DanTup

   on Oct 7, 2020

   Member

   More actions

   Ok, I think it may be possible to do this entirely in package.json - eg. add a setting and then use it in the where context for the debug/toolbar contributions - without any code changes/custom context. See this page under "Configuration settings contexts".

   If that works, I'd accept a contribution for that. I don't think it's worthwhile if we need to handle the config in code and maintain a context though.

   The setting should be named something so that it applies to all DevTools buttons and not just the inspector (if you run in profile mode, you'd see a Timeline button instead) - for ex. dart.showDevToolsInDebugToolbar.
8. DanTup

   added

   in commandsRelates to commands (usually invoked from the command Palette)Relates to commands (usually invoked from the command Palette)

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   and removed

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Oct 7, 2020
9. DanTup

   added this to the v3.16.0 milestone on Oct 7, 2020
10. DanTup

    added

    good first issue A relatively straight forward issue that could be done by a new contributorA relatively straight forward issue that could be done by a new contributor

    on Oct 8, 2020
11. DanTup

    changed the title [-]Hiding "DevTools Widget Inspector" button on debug toolbar[/-] [+]Allow hiding DevTools buttons from debug toolbar[/+] on Oct 13, 2020
12. DanTup

    closed this as completedin #2889on Oct 19, 2020