Don't sort test suites by status during a run #3093

Activity

1. DanTup

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   in testingRelates to test execution of Dart/Flutter tests for end usersRelates to test execution of Dart/Flutter tests for end users

   on Jan 23, 2021
2. DanTup

   added this to the v3.19.0 milestone on Jan 23, 2021
3. DanTup

   changed the title [-]Don't sort test suites by status[/-] [+]Don't sort test suites by status during a run[/+] on Jan 23, 2021
4. DanTup commented on Jan 23, 2021

   

   DanTup

   on Jan 23, 2021

   MemberAuthor

   More actions

   Actually, this is intended to be handled as described here:

   Dart-Code/src/shared/test/test_model.ts

   Lines 26 to 30 in 644393f

   	// To avoid the sort changing on every status change (stale, running, etc.) this
   	// field will be the last status the user would care about (pass/fail/skip).
   	// Default to Passed just so things default to the most likely (hopefully) place. This should
   	// never be used for rendering; only sorting.
   	protected _sort: TestSortOrder = TestSortOrder.Middle; // tslint:disable-line:variable-name

   Might have become broken in the change from TestStatus -> Set<TestStatus> to support running skips.
5. DanTup

   added a commit that references this issue on Jan 23, 2021

   Keep track of stale test statuses in container nodes when tests start…

   ...

   This issue will close once commit 15885b1 is merged into the 'master' branch.

   15885b1
6. DanTup

   closed this as completedin 2a1c825on Jan 23, 2021