Skip to content

Make build notifications uses Notifications instead of Window progress #3118

Closed
#3123
Closed
Make build notifications uses Notifications instead of Window progress#3118
#3123
Labels
in debuggingRelates to the debug adapter or process of running debug sessionsin flutterRelates to running Flutter appsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
Milestone
v3.20.0

Description

@DanTup
DanTup
opened on Feb 2, 2021

#2970 was intended to make hot reload/restart progress configurable, but leave build progress larger (notifications). However it appears the condition is accidentally make all non-hot-reload notifications smaller too.

The condition should be:

  • if not hot reload/hot restart, always Notification
  • else, use the config.hotReloadProgress setting to decide

Activity

  1. DanTup
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in flutterRelates to running Flutter apps
    in debuggingRelates to the debug adapter or process of running debug sessions
    on Feb 2, 2021
  2. DanTup
    added this to the v3.20.0 milestone on Feb 2, 2021
  3. DanTup
    closed this as completedin #3123on Feb 4, 2021
  4. DanTup
    added a commit that references this issue on Feb 4, 2021

    Only apply config.hotReloadProgress to hot-notifications

    c76d84e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsin flutterRelates to running Flutter appsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions