Skip to content

Theme annotation token #3161

Closed
Closed

Description

@HadyMash

Is your feature request related to a problem? Please describe.
There was previously an issue with the Preview LSP option where the UI Guides wouldn't work. When that was fixed, I turned it back on and noticed the syntax highlighting was different. I opened #3155 and I was able to change the colour of the variables. However, the @ and override have different colours and it doesn't match. Prior to turning on Preview LSP, using the One Dark Pro theme the @override would be pink. I do not care about what colour it is so long as they have the same colour.

Describe the solution you'd like
As advised by @DanTup in the previous issue, I would like to have a token for annotations so the @ colour can be customised.

Additional context
Issue #3155

Activity

  1. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on Feb 24, 2021
  2. DanTup commented on Feb 25, 2021

    @DanTup
    Member

    I've changed annotations to by default be coloured the same as variables:

    Screenshot 2021-02-25 at 11 36 17

    This won't match perfectly if you use a constructor directly (@ClassFoo()) as classes are coloured slightly differently, but I think in most cases annotations are fields/getters.

    You can also override the colour of the @ using the annotation token in your settings like:

    "editor.semanticTokenColorCustomizations": {
    	"rules": {
    		"annotation": "#00ff00",
    	},
    },
  3. added this to the v3.20.0 milestone on Feb 25, 2021
  4. added
    in editorRelates to code editing or language features
    on Feb 25, 2021
  5. HadyMash commented on Feb 25, 2021

    @HadyMash
    Author

    Thank you very much for your help @DanTup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions