Repository navigation
Code completion incorrectly returns results in comments at end of file #3170
Description
To Reproduce
- Open a new
foo.dartfile. - Start typing a comment "// This is a test."
- Notice how you end up with "// This is a test.abstract\n".
Expected behavior
I would have expected typing return after the period to result in just a new line, not "abstract\n" added.
The autocomplete is just a bit aggressive inside comments (especially with nothing typed after the period).
Screenshots
Versions (please complete the following information):
flutter doctor -v
[√] Flutter (Channel dev, 1.27.0-8.0.pre, on Microsoft Windows [Version 10.0.19041.804],
locale en-US)
• Flutter version 1.27.0-8.0.pre at C:\Users\micro\flutter
• Framework revision b7d4806243 (8 days ago), 2021-02-19 09:22:45 -0800
• Engine revision 6993cb229b
• Dart version 2.13.0 (build 2.13.0-30.0.dev)
[√] VS Code (version 1.53.2)
• VS Code at C:\Users\micro\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.16.0
Activity
DanTup commentedon Feb 28, 2021
Thanks! I can repro this - it seems to only happen when the comment is the last thing in the file. I suspect this check isn't working right in that case.
It also seems to set the replacement range to the whole comment, so if you invoke completion without the
.it ends up replacing the whole thing:I'll take a look, thanks!
[-]DartCode (or the analyzer?) unnecessarily completes after periods in comments[/-][+]Code completion incorrectly returns results in comments at end of file[/+][analyzer] Detect completion inside comments at the end of file
DanTup commentedon Mar 2, 2021
Fixed by dart-lang/sdk@f03ec46. The fix is in the SDK, so will show up in a future SDK update (rather than a Dart-Code update). Thanks!