Repository navigation
Intellisense for nullable types does not display the null postfix operator #3174
Description
Describe the bug
While working in a null safe dart project, if you start to type out a member from a class like fooClass., the intellisense popup does not display the null postfix operator:
Notice the type is LiveForexQuote.
But hovering over the member, then the correct type (nullable) is shown:
To Reproduce
Steps to reproduce the behavior:
- Create a nullable variable in a class
- Start typing to dereference that nullable class member
- Intellisense won't show the null postfix operator.
Expected behavior
Should show the null postfix operator like when you hover over it after typing it in.
Versions (please complete the following information):
Version: 1.53.0-exploration
Commit: 0c9e2dadd986d0bc085f1c5352245531eef65e84
Date: 2021-01-07T06:28:46.730Z (1 mo ago)
Electron: 11.1.0
Chrome: 87.0.4280.88
Node.js: 12.18.3
V8: 8.7.220.29-electron.0
OS: Darwin arm64 20.2.0
Dart code: 3.20.0
Activity
DanTup commentedon Apr 26, 2021
@bwilkerson this appears to be because
DartType.getDisplayStringcalls that assume non-null here:https://github.com/dart-lang/sdk/blob/b10a592341bec4a00379d5c674a417b6b8c781a6/pkg/analysis_server/lib/src/protocol_server.dart#L57-L75
If I change them to something like:
It seems to handle this, but it leaves me with some questions:
getDisplayStringsince it can accesselement?.declaration?.library?.isNonNullableByDefaultdirectly?bwilkerson commentedon Apr 26, 2021
Good question. I'm not sure what users want to see, but we've been using the principle that we should show the type that something has in the location at which it is referenced. If a top-level variable
int? x;is declared in an opted in library, but is referenced from an opted out library, then we don't show the nullability marker. This matches what the spec says, and in the absence of evidence that that's wrong, it seems like a reasonable default.DanTup commentedon Apr 27, 2021
Sounds good to me - I've opened https://dart-review.googlesource.com/c/sdk/+/197042/.
DanTup commentedon Apr 27, 2021
Fixed by dart-lang/sdk@115a758.