Skip to content

Renames that produce no edits should not trigger VS Code refactor prompt #3253

Closed

Description

@DanTup

Renaming a .dart file that is not referenced in any imports currently still triggers the VS Code rename/refactor prompt.

Activity

  1. added this to the v3.22.0 milestone on Apr 5, 2021
  2. DanTup commented on Apr 5, 2021

    @DanTup
    MemberAuthor

    I've got a fix here (that may or may not be required), but it doesn't work correctly because of dart-lang/sdk#45593.

  3. DanTup commented on Apr 6, 2021

    @DanTup
    MemberAuthor

    Between 749c2c8 and dart-lang/sdk#45593, this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions