Skip to content

export Quick-fix should include Create file 'path' #3269

Closed
Closed
export Quick-fix should include Create file 'path'#3269
Labels
in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
Milestone
v3.24.0

Description

@Luckey-Elijah
Luckey-Elijah
opened on Apr 9, 2021

Is your feature request related to a problem? Please describe.
With the part/part of ; directive quick fix feature, I sometimes expect the export directive to also have Create file 'path'; option in its quick fix menu.

Describe the solution you'd like
When the target URI doesn't exist (uri_does_not_exist) for an export directive, there should be a quick fix option: Create file 'path'.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

No Create file 'bar.dart;' in Quick Fix menu.

Screen Shot 2021-04-09 at 7 01 53 PM

But should create a file like:
Screen Shot 2021-04-09 at 7 04 00 PM

Activity

  1. Luckey-Elijah
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on Apr 9, 2021
  2. DanTup
    added
    in editorRelates to code editing or language features
    in lsp/analysis serverSomething to be fixed in the Dart analysis server
    on Apr 12, 2021
  3. DanTup
    added this to the On Deck milestone on Apr 12, 2021
  4. DanTup
    modified the milestones: On Deck, v3.24.0 on May 25, 2021

  5. DanTup commented on Jun 9, 2021

    @DanTup
    DanTup
    on Jun 9, 2021
    Member

    @bwilkerson do you see any reason not to support this for export as well as import? I'm not sure if it's deliberate or accidental (the use of ImportDirective here versus NamespaceDirective).

  6. bwilkerson commented on Jun 9, 2021

    @bwilkerson
    bwilkerson
    on Jun 9, 2021

    I believe it's an oversight.

  7. dart-bot
    added a commit that references this issue on Jun 9, 2021

    [analyzer] Enable create-file fix for export directives

    419fd67

  8. DanTup commented on Jun 10, 2021

    @DanTup
    DanTup
    on Jun 10, 2021
    Member

    This is fixed by dart-lang/sdk@419fd67 which will be included in a future Dart/Flutter SDK release.

  9. DanTup
    closed this as completedon Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions