Error text in debug console is low contrast with some themes #3326

Activity

1. iulian0512

   added

   is bug

   on May 7, 2021
2. DanTup

   added this to the v3.23.0 milestone on May 7, 2021
3. DanTup

   changed the title [-]Debug console exception log color[/-] [+]Error text in debug console is low contrast with some themes[/+] on May 7, 2021
4. DanTup

   added

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   on May 7, 2021
5. DanTup commented on May 10, 2021

   

   DanTup

   on May 10, 2021

   Member

   More actions

   @iulian0512 can you confirm which VS Code theme you're using (or if custom, can you provide the JSON/colour values)?

   Thanks!

   👍React with 👍1Reacted by iulian0512
6. iulian0512 commented on May 11, 2021

   

   iulian0512

   on May 11, 2021

   Last edited by iulian0512

   Author

   More actions

   @DanTup here is my complete theme
   vscodeGrayIulian.jsonc.txt
7. DanTup commented on May 17, 2021

   

   DanTup

   on May 17, 2021

   Member

   More actions

   Thanks! It looks like themes can set some of the ansi colours:

   "terminal.ansiBlack": "#000000",
   "terminal.ansiBlue": "#0000c0",
   "terminal.ansiBrightGrey": "#ff0000",
   "terminal.ansiBrightBlack": "#505050",
   "terminal.ansiBrightBlue": "#2080f0",
   "terminal.ansiBrightCyan": "#80f0f0",
   "terminal.ansiBrightGreen": "#80f080",
   "terminal.ansiBrightMagenta": "#f060f0",
   "terminal.ansiBrightRed": "#f04040",
   "terminal.ansiBrightWhite": "#ffffff",
   "terminal.ansiBrightYellow": "#f0f060",
   "terminal.ansiCyan": "#00b0b0",
   "terminal.ansiGreen": "#008000",
   "terminal.ansiMagenta": "#b000b0",
   "terminal.ansiRed": "#c00000",
   "terminal.ansiWhite": "#ffffe0",
   "terminal.ansiYellow": "#808000",
   

   We're currently using some grayscale values to try and dim text here, but those colours are not customisable and don't look great outside of fairly-dark or fairly-light backgrounds.

   I'll see if I can find some alternatives in the customisable set, otherwise we might need to make this toggleable.

   👍React with 👍1Reacted by iulian0512

   🚀React with 🚀1Reacted by iulian0512
8. DanTup

   closed this as completedin fb56df7on May 18, 2021
9. DanTup commented on May 18, 2021

   

   DanTup

   on May 18, 2021

   Member

   More actions

   I've removed the. use of custom grey colours, and now write text as stderr where we want it red, and stdout otherwise. The only ansi code used is to fade the colour of stack frames that aren't part of your own code (which seems to work well for all themes).

   Here's how it looks in Dark Theme:

   

   Light theme:

   

   Custom theme above (although I updated "debugConsole.errorForeground": "#990000" because it was originaly set to black and the error messages were less clear).

   

   This should work better for all themes now, and be more customisable since it doesn't use codes that aren't themable in VS Code.

   👍React with 👍1Reacted by iulian0512

   ❤️React with ❤️1Reacted by iulian0512
10. iulian0512 commented on May 18, 2021

    

    iulian0512

    on May 18, 2021

    Author

    More actions

    it looks wonderful thanks.
11. DanTup

    added 2 commits that reference this issue on May 19, 2021

    Look for stake traces in stdout now only red text goes to stderr

    ...

    d3ec518

    Update color tests to account for new reset code

    ...

    e42c460