Repository navigation
Support activating for workspaces that include virtual folders (like LiveShare) (virtual workspaces will have limited functionality) #3340
Description
Hello!
Describe the bug
I've been using this extension in conjunction with VSCode's Liveshare feature. Everything was working fine until a few days ago, since which time this extension does simply not work. I don't see any code highlighting, everything's just grey. I can't do any code navigation, nor can I even use a simple cmd + /. Quaintly enough, VSCode live share works perfectly for shared YAML or JSON files.
On the host's computer, all highlighting works perfectly, but on another editor's computer, the Dart extension simply doesn't work. It displays an error; "This plugin doesn't support virtual workspaces." I commented on the issue regarding support for virtual workspaces, and a maintainer requested me to file a separate issue.
To Reproduce
Steps to reproduce the behavior:
- Install the LiveShare extension pack
- Start a session
- Join the session from another computer
- Open any shared
.dartfile. - See error
Expected behavior
Code highlighting, code navigation, general working of an extension.
Screenshots
Versions (please complete the following information):
- VS Code version: v1.56
- Dart extension version: v3.22.0
- Dart/Flutter SDK version: Channel stable, 2.0.4,
>=2.7.0 <3.0.0inpubspec.yaml. Not converted tonull-safeyet because packages don't support it.
Thank you so much in advance.
Activity
DanTup commentedon May 13, 2021
I suspect this is a result of VS Code blacklisting many extensions from workspaces with virtual folders by default in the most recent relese:
https://github.com/microsoft/vscode/wiki/Virtual-Workspaces
Although there are no immediate plans to support virtual workspaces, we should be able to activate the extension and work for the non-virtual folders in the workspace at least (which would also allow the textmate grammar to be loaded).
[-]Extension not Working on VSCode LiveShare[/-][+]Support activating for workspaces that include virtual folders (like LiveShare) (virtual workspaces will have limited functionality)[/+]DanTup commentedon May 17, 2021
I've pushed a fix that will allow the extension to activate in virtual workspaces, although this does not add language support for it. Basic things like syntax highlighting will work.
#3327 is open for investigating better support for virtual workspaces, although it's not clear whether that will be feasible (or if so, to what extend) yet.
ranjithrd commentedon May 18, 2021
Thanks a ton, @DanTup ! Just confirming that this will be out on Jun 1 with v3.23.0 right?
DanTup commentedon May 18, 2021
Not set in stone, but it should be in the next release somewhere around then. There will likely be a beta release a little in advance if you'd like it sooner.
To re-iterate, this only allows the extension to activate, which will fix things like the textmate grammar (syntax highlighting) not being loaded. It doesn't add Dart-language support for virtual workspaces - however with LiveShare they should be proxied over to the host, so you should still see language functionality (though I would also expect that today even without this fix).
ranjithrd commentedon May 18, 2021
Alright. Thank you so much for all your help!
DanTup commentedon May 26, 2021
There's a beta version here if you'd like to test it out early:
https://github.com/Dart-Code/Dart-Code/releases/tag/v3.23.0-beta.1
If it doesn't work as expected, please let me know so I can fix before release. Thanks!