Convert to StatefulWidget adds an extra underscore to private widgets

Describe the bug
If you have a private StatelessWidget that you'd like to turn into a StatefulWidget, when you using the VS Code helper to do so your new State class will be prefixed with an extra underscore:

For example, if your class name was _MyCustomWidget, when using Convert to StatefulWidget the new state generated will be__MyCustomWidgetState (notice the two underscores at the beginning)

To Reproduce

Create a private StatelessWidget
Click on Convert to StatefulWidget and see the new state being prefixed by 2 underscores.

Expected behavior
The new state generated only has one underscore.

Versions (please complete the following information):

VS Code version: 1.56.2
Dart extension version: 3.22.0
Dart/Flutter SDK version: Flutter (Channel beta, 2.2.0-10.3.pre, on macOS 11.2.3 20D91 darwin-x64, locale en-US)

I will fork the project and try to provide a fix for this.

Thanks for the report! This fix actually comes from the Dart analysis server, so the fix will need to be made there.

If you'd like to contribute this, I believe the relevant code is here:

https://github.com/dart-lang/sdk/blob/bee609fd6b09d3e122ab279d58d9154a7f5f1263/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateful_widget.dart#L60

And tests for this functionality are at:

https://github.com/dart-lang/sdk/blob/bee609fd6b09d3e122ab279d58d9154a7f5f1263/pkg/analysis_server/test/src/services/correction/assist/flutter_convert_to_stateful_widget_test.dart

You'd need to clone and set up the Dart SDK, instructions for which are here:

Otherwise, if that's more involved than you'd expected and you'd prefer someone else to fix it, I'm happy to have a look - just let me know. Thanks!

Oh thank you for pointing me in the right direction! This is super helpful! I will make the changes there ;)

I have a PR submitted https://dart-review.googlesource.com/c/sdk/+/200720

@mrbirb

@mrbirb great! You'll need to run "Dart: Sort Members" in the analysis_server/test/src/services/correction/assist/flutter_convert_to_stateful_widget_test.dart file to fix the test failure.

@DanTup

@DanTup Done :D

Awesome - thanks! I'll close this once that change is merged :-)

@mrbirb

Wohooo! Thank you @mrbirb !!!

Convert private widget to Stateful without extra underscore.

Fixed by dart-lang/sdk@5051d4b which will be included in a future SDK update.

@DanTup

Hi @DanTup , I am not seeing this is the lastest SDK. Am I missing something?

Flutter 2.2.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision d79295af24 (7 days ago) • 2021-06-11 08:56:01 -0700
Engine • revision 91c9fc8fe0
Tools • Dart 2.13.3

@Mayb3Nots

@Mayb3Nots the hotfix releases only include very specific fixes for critical issues, so this will only show up with the next normal release (eg. 2.3 or later, not 2.2.x releases). Sorry for the confusion!

@Mayb3Nots

@Mayb3Nots the hotfix releases only include very specific fixes for critical issues, so this will only show up with the next normal release (eg. 2.3 or later, not 2.2.x releases). Sorry for the confusion!

Thanks for the clarification, was wondering why some of the fixes wasnt working.

Navigation Menu

Repository navigation

Convert to StatefulWidget adds an extra underscore to private widgets #3343

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Convert to StatefulWidget adds an extra underscore to private widgets #3343

Description

Activity

jorgecoca commented on May 14, 2021

DanTup commented on May 17, 2021

jorgecoca commented on May 17, 2021

thecalamiity commented on May 19, 2021

DanTup commented on May 20, 2021

thecalamiity commented on May 20, 2021

DanTup commented on May 20, 2021

jorgecoca commented on May 20, 2021

DanTup commented on May 25, 2021

Mayb3Nots commented on Jun 18, 2021

DanTup commented on Jun 18, 2021

Mayb3Nots commented on Jun 18, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions