serviceInfoFile doesn't seem to work for custom flutter embedders #3353

Activity

1. knopp

   added

   is bug

   on May 18, 2021
2. knopp

   changed the title [-]serviceInfoFile doesn't seem to work for flutter[/-] [+]serviceInfoFile doesn't seem to work for custom flutter embedders[/+] on May 18, 2021
3. knopp commented on May 18, 2021

   

   knopp

   on May 18, 2021

   Last edited by knopp

   Author

   More actions

   The application is not built through the flutter tool so I can't run it using flutter run. flutter attach works, but I need to specify vmServiceUri on every launch.

   (down the line it would also be nice to have option for Dart-Code to launch a custom executable with --write-service-info), but for now at least serviceInfoFile working would be a big quality of life improvement.
4. DanTup

   added this to the v3.23.0 milestone on May 19, 2021
5. DanTup

   added

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   in flutterRelates to running Flutter appsRelates to running Flutter apps

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   and removed

   is bug

   on May 19, 2021
6. DanTup commented on May 19, 2021

   

   DanTup

   on May 19, 2021

   Last edited by DanTup

   Member

   More actions

   down the line it would also be nice to have option for Dart-Code to launch a custom executable with --write-service-info

   You might be able to do this with a preLaunchTask (eg. cause the debug config to run a background task that spawns the app before it tries to debug) or a compound config (one that runs a Dart script that sets up the file and spawns your process) - I don't know how messy that would be though.

   There is also some support for overriding the Flutter/Dart binaries, but it's aimed at some specific Bazel workspace setups so not something official supported for this, but may be another option to improve things until/unless something better is available:

   Dart-Code/src/shared/utils/workspace.ts

   Lines 57 to 69 in 195b1c6

   	config.activateDevToolsEagerly = !!flutterConfig.devtoolsActivateScript;
   	config.dartSdkHomeLinux = makeFullPath(flutterConfig.dartSdkHome?.linux);
   	config.dartSdkHomeMac = makeFullPath(flutterConfig.dartSdkHome?.macos);
   	// This one replaces the args "global activate devtools"
   	config.devtoolsActivateScript = makeScript(flutterConfig.devtoolsActivateScript, 3);
   	// This one replaces the args "global run devtools"
   	config.devtoolsRunScript = makeScript(flutterConfig.devtoolsRunScript, 3);
   	config.flutterDaemonScript = makeScript(flutterConfig.daemonScript);
   	config.flutterDoctorScript = makeScript(flutterConfig.doctorScript);
   	config.flutterRunScript = makeScript(flutterConfig.runScript);
   	config.flutterSdkHome = makeFullPath(flutterConfig.sdkHome);
   	config.flutterTestScript = makeScript(flutterConfig.testScript);
   	config.flutterVersionFile = makeFullPath(flutterConfig.versionFile);

   As for the original request - looking at FlutterDebugSession, attachRequest calls launchRequest which calls into DartDebugSession.launchRequest so I don't think it should be complicated to fix this - I suspect there are just some bad assumptions somewhere.
7. DanTup

   closed this as completedin b1e60aeon May 19, 2021
8. DanTup commented on May 19, 2021

   

   DanTup

   on May 19, 2021

   Member

   More actions

   Although this works in my testing with simple Flutter, it's not working for @knopp:

   [1:28:22 PM] [FlutterRun] [Info] [Flutter: Attach to Process] Spawning flutter with args ["attach","--machine","-d","macos","--debug-uri","ws://127.0.0.1:60238/40DHMrlkLa0=/ws","--devtools-server-address","http://127.0.0.1:9100/","-v"]
   
   [ +104 ms] Exception attempting to connect to the VM Service: WebSocketException: Connection to 'http://127.0.0.1:60238/40DHMrlkLa0=/ws/ws#' was not upgraded to websocket
   

   The /ws/ws looks suspicious - though it's interesting I'm not seeing that (I did see the URL mangled in a different way though, it ended up with .,/ws on the end - but it still worked). Perhaps something changed in Flutter (I'm on master).
9. DanTup

   reopened this on May 19, 2021
10. DanTup

    closed this as completedin 4151a7eon May 19, 2021
11. auto-submit

    added a commit that references this issue on Jun 16, 2023

    [flutter_tools] Add support for vmServiceFileInfo when attaching (#12…

    ...

    dc4541f