Skip to content

Hot restart doesn't work if debugging progress is not done #3550

Closed

Description

@tbm98

loading forever when click hot restart when debugging progress is not done.

it works ok when debugging is done

Screenshots
error when not done

Screen.Recording.2021-09-03.at.11.28.49.mov

no error when done

Screen.Recording.2021-09-03.at.11.33.42.mov

minimal repo: here

Versions (please complete the following information):

  • VS Code version: 1.60.0
  • Dart extension version: 3.26.0
  • Dart/Flutter SDK version: flutter dev 2.6.0-0.0.pre

Activity

  1. DanTup commented on Oct 18, 2021

    @DanTup
    Member

    Sorry about the delay - the notification for this issue got buried in my inbox and I only just found it :-(

    I believe this may be the same issue as #3448, but I will do some debugging to verify and try to make sure both are fixed for the upcoming release. Thanks!

  2. added
    in debuggingRelates to the debug adapter or process of running debug sessions
    in flutterRelates to running Flutter apps
    on Oct 18, 2021
  3. added this to the v3.28.0 milestone on Oct 18, 2021
  4. DanTup commented on Oct 26, 2021

    @DanTup
    Member

    @tbm98 I wasn't able to repro your issue using the linked repository (it doesn't seem to contain the same line that throws an exception as your video), although I've published a beta release that includes the fix I mentioned above if you'd like to try it out and confirm it resolves the issue:

    https://github.com/Dart-Code/Dart-Code/releases/tag/v3.28.0-beta.1

  5. tbm98 commented on Oct 26, 2021

    @tbm98
    Author

    @DanTup can you checkout to this commit and try again. I can't test right now because I just return the computer to company 😄

  6. DanTup commented on Oct 27, 2021

    @DanTup
    Member

    @tbm98 thanks! I repro'd with that commit, then installed the beta release above and the issue is resolved. The hot reload now completely successfully, even if initiated while hitting the exceptions. Thanks!

  7. tbm98 commented on Oct 27, 2021

    @tbm98
    Author

    Many thanks 😄

  8. DanTup commented on Oct 27, 2021

    @DanTup
    Member

    There were some issues in that beta, there's a new one here:

    https://github.com/Dart-Code/Dart-Code/releases/tag/v3.28.0-beta.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsin flutterRelates to running Flutter appsis bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions