Skip to content

Launch DevTools from "dart devtools" instead of "pub global" when using SDK >= 2.15 #3584

Closed
Closed
Launch DevTools from "dart devtools" instead of "pub global" when using SDK >= 2.15#3584
Labels
importantSomething important!in commandsRelates to commands (usually invoked from the command Palette)is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
Milestone
v3.28.0

Description

@DanTup
DanTup
opened on Sep 29, 2021

See flutter/flutter#90894 (comment).

We can skip activating via Pub, checking for updates, etc. if we use the SDK-supplied command.

From flutter/flutter#90894 (comment)

2.15.0-39.0.dev is the earliest dart version this commit was included in.

@helin24 currently for internal workspaces we set startDevToolsFromDaemon and start from the Flutter daemon. I'm assuming that should remain as-is, but if that's no longer required let me know and I can remove it.

Activity

  1. DanTup
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in commandsRelates to commands (usually invoked from the command Palette)
    on Sep 29, 2021
  2. DanTup
    modified the milestones: v3.27.0, v3.28.0 on Sep 29, 2021
  3. DanTup
    added
    importantSomething important!
    on Oct 21, 2021
  4. DanTup
    closed this as completedin aad48f3on Oct 25, 2021

  5. helin24 commented on Apr 15, 2022

    @helin24
    helin24
    on Apr 15, 2022
    Contributor

    @kenzieschmoll I believe we can use dart directly for internal workspaces, is that correct? Internal workspace's have a dart with a version above 2.15.0-39.0.dev and can therefore start devtools the same way? (asking now as I'm making this change for IntelliJ)

  6. kenzieschmoll commented on Apr 18, 2022

    @kenzieschmoll
    kenzieschmoll
    on Apr 18, 2022

    there are pre-built binaries DevTools binaries in google3 that should be used to start devtools. The DevTools build bundled with the external Dart SDK is not the same as the google3 DevTools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    importantSomething important!in commandsRelates to commands (usually invoked from the command Palette)is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions