Add support for Inlay Hints for (unnamed) parameter names #3609

Activity

1. ghost added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Oct 12, 2021
2. DanTup

   changed the title [-]Add support for Inlay Hints[/-] [+]Add support for Inlay Hints for (unnamed) parameter names[/+] on Oct 12, 2021
3. DanTup commented on Oct 12, 2021

   

   DanTup

   on Oct 12, 2021

   Member

   More actions

   In your previous screenshot there were two places inlay hints were being used:

   1. At the call site of functions, to show the names of arguments (that are not already named)
   2. Were types are being inferred and not present in the source code

   Although both use inlay hints, the implementation of these is quite separate and I think make sense to track separately (for example one could be shipped without the other).

   I've updated the name of this issue to assume the first - it's worth filing a separate issue about the other one too.

   Right now, use of Inlay Hints is blocked on LSP support which is in progress at microsoft/language-server-protocol#956.
4. DanTup

   added this to the Backlog milestone on Oct 12, 2021
5. DanTup

   added

   blocked on vs code / lsp / dapRequires a change in VS Code to progressRequires a change in VS Code to progress

   in editorRelates to code editing or language featuresRelates to code editing or language features

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Oct 12, 2021
6. RedyAu commented on Jan 31, 2022

   

   RedyAu

   on Jan 31, 2022

   More actions

   I would like to second this issue, would be very useful. VSCode has an inlay hints setting now; maybe the situation has changed since?
   
   Enabling this has no effect for .dart files.

   👍React with 👍2Reacted by LX and Bruno D'Luka
7. DanTup commented on Jan 31, 2022

   

   DanTup

   on Jan 31, 2022

   Member

   More actions

   @RedyAu Dart uses LSP, so nothing could be started on this until it's been available in LSP:

   microsoft/language-server-protocol#956

   😕React with 😕1Reacted by Fodor Benedek
8. sanathusk commented on Jul 6, 2022

   

   sanathusk

   on Jul 6, 2022

   Last edited by sanathusk

   More actions

   The VS Code API has been finalized: microsoft/vscode#16221 (comment). I would love to see the feature implemented in vscode for dart .Vscode already supports it for JavaScript & typescript.
9. DanTup

   removed

   blocked on vs code / lsp / dapRequires a change in VS Code to progressRequires a change in VS Code to progress

   on Jul 7, 2022
10. DanTup

    modified the milestones: Backlog, v3.50.0 on Sep 12, 2022
11. DanTup commented on Sep 14, 2022

    

    DanTup

    on Sep 14, 2022

    Member

    More actions

    Start working on this at https://dart-review.googlesource.com/c/sdk/+/259181/.

    

    It's in the language server, so will become part of a future Dart/Flutter SDK release rather than a Dart-Code release.
12. DanTup

    added

    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become availableSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    on Sep 14, 2022
13. DanTup commented on Sep 14, 2022

    

    DanTup

    on Sep 14, 2022

    Member

    More actions

    Landed in dart-lang/sdk@15dfda9.

    🚀React with 🚀1Reacted by Lenz Paul
14. DanTup

    closed this as completedon Sep 14, 2022
15. DanTup

    modified the milestones: v3.50.0, Next SDK Release on Oct 3, 2022