Repository navigation
Completing a method/constructor name with no typed prefix inserts parenthesis even if already present #3672
Description
Describe the bug
v3.28.0 Places odd braces on autocompletion where there is already an existing pair
To Reproduce
Steps to reproduce the behavior:
Write some code like
Container(
child: Padding(
padding: EdgeInsets.all(8.0),
child: Column(
children: [
],
),
),
)- erase "all" constructor name and type, e.g. symm
- When it prompts "symmetric" press enter to autocomplete it
- You will see odd pair of braces like this and the cursor between them
Container(
child: Padding(
padding: EdgeInsets.symmetric()(8.0),
child: Column(
children: [
],
),
),
)Expected behavior
No braces added because there is already a pair of them right next to the prompted code
in this case with (8.0) inside
Screenshots
2021-11-16.19.04.55.mov
Versions (please complete the following information):
- VS Code version: 1.62.2
- Dart extension version: v3.28.0
- Dart/Flutter SDK version: Dart 2.13.4 (stable), Flutter 2.2.3 (stable)
Activity
DanTup commentedon Nov 16, 2021
Thanks! This seems to be happen when there's no prefix already typed in the code:
The second expression is evaluated as a property named
(and the existing arglist detection didn't handle it. I've got a fix up for review at https://dart-review.googlesource.com/c/sdk/+/220380/.[-]Incorrect brace placing in v3.28.0[/-][+]Completing a method/constructor name with no typed prefix inserts parenthesis even if already present[/+][analysis_server] Prevent duplicate parens on completion for members …
DanTup commentedon Nov 16, 2021
Fixed by dart-lang/sdk@327389b.